Bug #71385 for Tie-LevelDB: [PATCH] Raise Perl level exception on error

> Sat Oct 01 13:17:53 2011: Request 71385 was acted upon. > Transaction: Ticket created by DGL > Queue: Tie-LevelDB > Subject: [PATCH] Raise Perl level exception on error > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dgl@dgl.cx > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=71385 > > > > Avoids segfaulting on attempting to open a locked DB. > --- > LevelDB.xs | 4 +++- > t/Tie-LevelDB.t | 11 ++++++++++- > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/LevelDB.xs b/LevelDB.xs > index 59e29aa..a7aa9bb 100644 > --- a/LevelDB.xs > +++ b/LevelDB.xs > @@ -22,7 +22,9 @@ extern "C" { > #include<leveldb/write_batch.h> > > void status_assert(leveldb::Status s) { > - if(!s.ok()) std::cerr << s.ToString() << std::endl; > + if(!s.ok()) { > + croak(s.ToString().c_str()); > + } > } > > class Iterator { > diff --git a/t/Tie-LevelDB.t b/t/Tie-LevelDB.t > index f496946..887568f 100644 > --- a/t/Tie-LevelDB.t > +++ b/t/Tie-LevelDB.t > @@ -5,7 +5,7 @@ > > # change 'tests => 1' to 'tests => last_test_to_print'; > > -use Test::More tests => 29; > +use Test::More tests => 30; > BEGIN { use_ok('Tie::LevelDB') }; > > ######################### > @@ -87,6 +87,15 @@ delete $h{'goner2'}; > > is(scalar(keys %h), 2); > > +open my $fh, "|-", $^X, "-Mblib" or die $!; > +print $fh <<EOF; > +use $LevelDB_Class; > +eval { tie my %h, "$LevelDB_Class", "$DBDIR" }; > +die if \$@ !~ /LOCK/; > +EOF > +close $fh; > +ok +($? >> 8) == 0, "Unable to open locked DB"; > + > untie %h; > > is(scalar(keys %h), 0); > -- > 1.7.4.4 > > >