Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-DBIx-Class CPAN distribution.

Report information
The Basics
Id: 71305
Status: resolved
Priority: 0/
Queue: Test-DBIx-Class

People
Owner: Nobody in particular
Requestors: richard.foley [...] rfi.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.21
Fixed in: (no value)



Messy diagnostic info from failure to clean up cleanly in cleanup(). (in cleanup) Can't call method "name" on an undefined value at /usr/lib64/perl5/vendor_perl/5.12.4/Test/DBIx/Class/SchemaManager.pm line 187 during global destruction. (in cleanup) Can't call method "with_deferred_fk_checks" on an undefined value at /usr/lib64/perl5/vendor_perl/5.12.4/Test/DBIx/Class/SchemaManager.pm line 192 during global destruction. # minor patch required to fix - attached. -- http://www.rfi.net
Subject: SchemaManager.pm.diff
--- SchemaManager.pm.orig 2011-09-28 14:06:16.490973830 +0200 +++ SchemaManager.pm.fix 2011-09-28 14:07:25.232586347 +0200 @@ -180,11 +180,14 @@ my $schema = $self->schema; return unless $schema; + return unless $schema->storage; unless ($self->keep_db) { $schema->storage->with_deferred_fk_checks(sub { foreach my $source ($schema->sources) { - my $table = $schema->source($source)->name; + my $tablesource = $schema->source($source); + next unless $tablesource; + my $table = $tablesource->name; $schema->storage->dbh->do("drop table $table") if !($schema->source($source)->can('is_virtual') && $schema->source($source)->is_virtual);
Subject: on to cpan
Hey, I applied your patch and tested, seemed good so there is a new version on CPAN. If you get a moment I'd love for you to test 0.23 out sometime and let me know if all is well johnn On Wed Sep 28 08:11:45 2011, RFOLEY wrote: Show quoted text
> Messy diagnostic info from failure to clean up cleanly in cleanup(). > > (in cleanup) Can't call method "name" on an undefined value at > /usr/lib64/perl5/vendor_perl/5.12.4/Test/DBIx/Class/SchemaManager.pm > line 187 during global destruction. > (in cleanup) Can't call method "with_deferred_fk_checks" on an undefined > value at > /usr/lib64/perl5/vendor_perl/5.12.4/Test/DBIx/Class/SchemaManager.pm > line 192 during global destruction. > > > # minor patch required to fix - attached.
Subject: Re: [rt.cpan.org #71305] on to cpan
Date: Wed, 28 Sep 2011 17:04:42 +0200
To: John Napiorkowski via RT <bug-Test-DBIx-Class [...] rt.cpan.org>
From: Richard Foley <richard.foley [...] rfi.net>
Hi John, Glad to be of help, and even better to hear your tests went well, too. All good. Ciao Richard -- Richard Foley Ciao - shorter than AufWiederSehen! http://www.rfi.net/books.html On Wed, Sep 28, 2011 at 10:22:12AM -0400, John Napiorkowski via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=71305 > > > Hey, > > I applied your patch and tested, seemed good so there is a new version on CPAN. If you get a > moment I'd love for you to test 0.23 out sometime and let me know if all is well > > johnn > > On Wed Sep 28 08:11:45 2011, RFOLEY wrote:
> > Messy diagnostic info from failure to clean up cleanly in cleanup(). > > > > (in cleanup) Can't call method "name" on an undefined value at > > /usr/lib64/perl5/vendor_perl/5.12.4/Test/DBIx/Class/SchemaManager.pm > > line 187 during global destruction. > > (in cleanup) Can't call method "with_deferred_fk_checks" on an undefined > > value at > > /usr/lib64/perl5/vendor_perl/5.12.4/Test/DBIx/Class/SchemaManager.pm > > line 192 during global destruction. > > > > > > # minor patch required to fix - attached.
> >