Skip Menu |

This queue is for tickets about the Net-SAML2 CPAN distribution.

Report information
The Basics
Id: 71160
Status: resolved
Priority: 0/
Queue: Net-SAML2

People
Owner: Nobody in particular
Requestors: perl [...] okko.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.15
Fixed in: 0.18



Subject: Default to 'signing' when no use attribute for KeyDescriptor of the IdP SAML
This is a fix for warning "Use of uninitialized value $use in hash element at lib/perl5/Net/SAML2/IdP.pm line 109" when the use attribute is not provided for the KeyDescriptor of the IdP SAML. In file Net/SAML2/IdP.pm: for my $key ($xpath- Show quoted text
>findnodes('//md:EntityDescriptor/md:IDPSSODescriptor/md:KeyDescriptor')
) { - my $use = $key->getAttribute('use'); + my $use = $key->getAttribute('use') || 'signing'; my ($text) = $key- Show quoted text
>findvalue('ds:KeyInfo/ds:X509Data/ds:X509Certificate') =~ /^\s*
(.+?)\s*$/s; I haven't yet tested how the SAML process works without this, though.
On Thu Sep 22 11:46:31 2011, Okko wrote: Show quoted text
> In file Net/SAML2/IdP.pm: > > for my $key ($xpath-
> >findnodes('//md:EntityDescriptor/md:IDPSSODescriptor/md:KeyDescriptor')
> ) { > - my $use = $key->getAttribute('use'); > + my $use = $key->getAttribute('use') || 'signing'; > my ($text) = $key-
> >findvalue('ds:KeyInfo/ds:X509Data/ds:X509Certificate') =~ /^\s*
> (.+?)\s*$/s;
This seems reasonable, if a key is provided but not explicitly declared to be for a specific purpose. Show quoted text
> I haven't yet tested how the SAML process works without this, though.
It should be OK, if this turns out to be the key used for signing. Can I ask which IdP you're using that behaves like this? Thanks
Thanks for a quick reply. On Thu Sep 22 12:02:15 2011, CHRISA wrote: Show quoted text
> Can I ask which IdP you're using that behaves like this?
It is a Shibboleth 2.x.
Fixed in 17.06