Bug #71018 for Parse-BBCode: Auto closing open tags, not happening always?

Fri Sep 16 08:50:20 2011 mendoza [...] pvv.ntnu.no - Ticket created

#!/usr/bin/perl use Test::More qw(tests 2); use Parse::BBCode; my $p = Parse::BBCode->new({ tags => { b => 'block:%s', i => 'block:%s', }, close_open_tags => 1, }); my @code = ('[b][i]text', '[b][i]text[/b]'); foreach(@code) { is($p->render($_), 'text', qq{Test that auto closing of open tags is consistent}); } I have an issue, it seems, with auto closing tags, please try the above tests, and notice that it doesn't try to close an inner tag if an outer tag is getting closed. I believe this should happen?

Sat Sep 17 06:13:17 2011 mendoza [...] pvv.ntnu.no - Subject changed from (no value) to 'Auto closing open tags, not happening always?'

Mon Sep 19 08:41:23 2011 mendoza [...] pvv.ntnu.no - Correspondence added

fr. 16. sep. 2011 08.50.20 skrev NICOMEN: Show quoted text

> #!/usr/bin/perl > > use Test::More qw(tests 2); > use Parse::BBCode; > > my $p = Parse::BBCode->new({ > tags => { > b => 'block:%s', > i => 'block:%s', > }, > close_open_tags => 1, > }); > > my @code = ('[b][i]text', '[b][i]text[/b]'); > > foreach(@code) { > is($p->render($_), 'text', qq{Test that auto closing

of Show quoted text

> open tags is consistent}); > } > > > I have an issue, it seems, with auto closing tags, please try the

above Show quoted text

> tests, and notice that it doesn't try to close an inner tag if an

outer Show quoted text

> tag is getting closed. I believe this should happen?

This patch seems to do the trick: diff -r Parse-BBCode-0.13/lib/Parse/BBCode.pm Parse-BBCode-0.13-nicomen/ lib/Parse/BBCode.pm 438c438,445 < $callback_found_tag->($_) for $try->_reduce; --- Show quoted text

> if ($self->get_close_open_tags) { > $f = $try; > unshift @not_close, $try; > if (@opened) { $opened[-1]->add_content

(''); } Show quoted text

> $self->_finish_tag($try, '[/'. $try- >get_name() .']'); > } else { > $callback_found_tag->($_) for $try- >_reduce; > }

Mon Sep 19 08:41:24 2011 mendoza [...] pvv.ntnu.no - Status changed from 'new' to 'open'

Tue Sep 20 06:46:44 2011 mendoza [...] pvv.ntnu.no - Correspondence added

Also there seems to be an issue with closing open tags, and not parsing the content. use Test::More tests => 6; use Test::NoWarnings; use Parse::BBCode; use strict; use warnings; my $p = Parse::BBCode->new({ tags => { b => '%s', i => '%s', noparse => { code => sub { my ($parser, $attr, $content, $attribute_fallback) = @_; return "${$content}"; }, parse => 0, }, }, close_open_tags => 1, }); my %tests = ( '[b][i]text' => 'text', '[b][i]text[/b]' => 'text', '[b][i]text[/i]' => 'text', '[b][noparse]text[/b]' => 'text', '[noparse][b]text[/b]' => '[b]text[/b]', ); while (my ($code, $exp) = each %tests) { my $tree = $p->parse($code); is($p->render_tree($tree), $exp, qq{Test that closening of opening tags is consistent}); } I have a patch for this too if you are interested

Sun Sep 25 10:43:14 2011 TINITA [...] cpan.org - Correspondence added

Am Fr 16. Sep 2011, 08:50:20, NICOMEN schrieb: Show quoted text

> I have an issue, it seems, with auto closing tags, please try the above > tests, and notice that it doesn't try to close an inner tag if an outer > tag is getting closed. I believe this should happen?

thanks! that's right, and I applied your patch. I'm looking into the other tickets now and hope I can make a release soon. regards, tina

Sun Sep 25 10:45:20 2011 TINITA [...] cpan.org - Correspondence added

Am Di 20. Sep 2011, 06:46:44, NICOMEN schrieb: Show quoted text

> Also there seems to be an issue with closing open tags, and not parsing > the content.

uh, yes, that's tricky. I fixed it. The fix doesn't look very elegant but the test suite suceeds =)

Mon Sep 26 07:20:48 2011 TINITA [...] cpan.org - Fixed in 0.13_001 added

Sun Jul 13 05:17:22 2014 TINITA [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #71018 for Parse-BBCode: Auto closing open tags, not happening always?

Maintainer(s)' notes