Subject: | Test failure on win32 |
Hello,
With this release of Carp, my Win32 build of Perl is failing two tests:
C:\strawberry\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e"
"test_harness(0,'blib\lib', 'blib\arch')" t/*.t
t/Carp.t ....... 1/58
# Failed test 'Carp can handle UTF8-flagged strings after a syntax error'
# at t/Carp.t line 396.
# ''
# doesn't match '(?-xism:aaaaa)'
# Failed test 'Carp does not autovivify *B::'
# at t/Carp.t line 412.
# got: ''
# expected: 'ok'
# Looks like you failed 2 tests of 58.
t/Carp.t ....... Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/58 subtests
(less 13 skipped subtests: 43 okay)
t/vivify_gv.t .. ok
Test Summary Report
-------------------
t/Carp.t (Wstat: 512 Tests: 58 Failed: 2)
Failed tests: 57-58
Non-zero exit status: 2
Files=2, Tests=61, 0 wallclock secs ( 0.05 usr + 0.02 sys = 0.06 CPU)
Result: FAIL
Failed 1/2 test programs. 2/61 subtests failed.
dmake: Error code 255, while making 'test_dynamic'
C:\strawberry\cpan\build\Carp-1.22-P_2yOE>perl -v
This is perl 5, version 12, subversion 3 (v5.12.3) built for
MSWin32-x64-multi-thread
This seems to be caused by those two test programs having the
double-quote in them. I don't know why it causes the programs to produce
no output, but I see in a couple other runperl() commands the quotes are
done using q{} instead. Doing this for those two programs solves the
test failures.
This patch fixes the test failures for me and I'm sure it will work with
other systems just fine:
From 47e25c56741e39ccc2ea82a835d8ed6976898fc8 Mon Sep 17 00:00:00 2001
From: Douglas Christopher Wilson <doug@somethingdoug.com>
Date: Fri, 9 Sep 2011 03:08:20 -0400
Subject: [PATCH] Change quotes in tests
---
t/Carp.t | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/Carp.t b/t/Carp.t
index edb4020..1a07c75 100644
--- a/t/Carp.t
+++ b/t/Carp.t
@@ -396,7 +396,7 @@ like(
runperl(
prog => q<
use utf8; use strict; use Carp;
- BEGIN { $SIG{__DIE__} = sub { Carp::croak "aaaaa$_[0]" } }
+ BEGIN { $SIG{__DIE__} = sub { Carp::croak qq{aaaaa$_[0]} } }
$c
Show quoted text
>,
stderr=>1,
@@ -414,8 +414,8 @@ SKIP:
prog => q<
use Carp;
$SIG{__WARN__} = sub{};
- carp ("A duck, but which duck?");
- print "ok" unless exists $::{"B::"};
+ carp (q{A duck, but which duck?});
+ print q{ok} unless exists $::{ q{B::} };
Show quoted text >,
),
'ok',
--
1.7.6.msysgit.0