Skip Menu |

This queue is for tickets about the Mojolicious-Plugin-Mail CPAN distribution.

Report information
The Basics
Id: 70814
Status: resolved
Priority: 0/
Queue: Mojolicious-Plugin-Mail

People
Owner: Nobody in particular
Requestors: casper [...] warming.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Changes in Mojo unicode breaks t/mail.t
Date: Thu, 8 Sep 2011 16:58:12 +0200
To: bug-mojolicious-plugin-mail [...] rt.cpan.org
From: Casper Warming <casper [...] warming.net>
Hi, According to sri, b($utf8_str_w_cyrillic)->b64_encode('') should be b($utf8_str_w_cyrillic)->encode('UTF-8')->b64_encode('') due to Mojo getting more strict unicode handling recently (see http://blogs.perl.org/users/aristotle/2011/08/utf8-flag.html) The actual error: # Building Mojolicious-Plugin-Mail # Wide character in subroutine entry at /home/cwg/perl5/perlbrew/perls/perl-5.14.1/lib/site_perl/5.14.1/Mojo/Util.pm line 304. # # Looks like you planned 148 tests but ran 16. The relevant #mojo irc log for reference: [15:53] cwg: Hi. Building Mojolicious::Plugin::Mail I get "Wide character in [snip] 5.12.1/Mojo/Util.pm line 304" (in b64_encode()). Mojo 1.97 on osx. Am I missing something known/obvious -or should I just go debug? [15:54] • sri waves [15:55] sri: cwg: b64_encode expect bytes, not characters [15:55] sri: *expects [15:55] • cwg checks *.t [15:59] sri: prolly a bug in Mojolicious::Plugin::Mail or its tests [16:00] sri: parts of mojolicious were more forgiving about unicode errors in the past [16:12] sri: cwg: you should definitely poke the author [16:14] cwg: Always with the poking. b($utf8_str_w_cyrillic)->b64_encode('') croaks here. Trying a fresh perlbrew. [16:19] sri: that should croak [16:19] sri: b($utf8_str_w_cyrillic)->encode('UTF-8')->b64_encode('') [16:19] sri: cwg: that should be there [16:21] • sri pokes cwg (just because) [16:33] cwg: So the relaxed unicode err handling allowed for this previously? https://github.com/sharifulin/mojolicious-plugin-mail/blob/master/t/mail.t#L243 [16:36] cwg: ..because then I know who/how to poke. And will shut up. [16:37] sri: cwg: correct [16:39] cwg: sri: neat. (snaps irclog) [16:40] sri: cwg: http://blogs.perl.org/users/aristotle/2011/08/utf8-flag.html # here's a link in case the person asks why the more forgiving unicode handling was bad I'm not sure, but it's probably just the t/mail.t thats affected. /casper
Hi! I can't see this warning using my test suite. Can you show me a little test script? I changed the test (t/mail.t), please see https://github.com/sharifulin/mojolicious-plugin- mail/commit/00a04f104f249c9e17d108bea0ff638763f3816f Lets use Github Issues ;) -- use Perl or die;