Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 70763
Status: open
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: STEFFENW [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: 1.116
Fixed in: (no value)

History Show all quoted text
  Tue Sep 06 10:12:14 2011 STEFFENW [...] cpan.org - Ticket created
Subject: Policy/ClassHierarchies/ProhibitExplicitISA.pm - add recommendation: use parent
"use base" and "use fields" are very old modules. 2007 the slim "use parent" was created that modificates @ISA only. That is all we need for inheritance. "use base" is much more. Please add "use parent" as alternative recommendation. --Steffen
  Tue Sep 06 11:14:12 2011 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #70763] Policy/ClassHierarchies/ProhibitExplicitISA.pm - add recommendation: use parent
Date: Tue, 06 Sep 2011 10:14:01 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Already in there under https://metacpan.org/module/Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA#NOTE
  Tue Sep 06 11:14:13 2011 The RT System itself - Status changed from 'new' to 'open'
  Tue Sep 06 15:19:04 2011 STEFFENW [...] cpan.org - Correspondence added
That's not really true. Noone reads the Pod of the rules. Only the messages are important. What I mean is: 0022: Readonly::Scalar my $DESC => q{@ISA used instead of "use base"}; ## no critic (RequireInterpolation) In another rule "lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMagicNumbers.p m" it is better: 0026: Readonly::Scalar my $USE_READONLY_OR_CONSTANT => 0027: ' Use the Readonly or Const::Fast module or the "constant" pragma instead';
  Tue Sep 06 15:58:21 2011 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #70763] Policy/ClassHierarchies/ProhibitExplicitISA.pm - add recommendation: use parent
Date: Tue, 06 Sep 2011 14:58:14 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
On 9/6/11 2:19 PM, Steffen Winkler via RT wrote: Show quoted text
> That's not really true. > Noone reads the Pod of the rules. Only the messages are important.
/I/ certainly do when I run into a violation. perlcritic --doc Whatever
  Tue Feb 28 13:39:51 2012 dolmen [...] cpan.org - Correspondence added
RT-Send-CC: perl [...] galumph.com
Le 2011-09-06 16:12:14, STEFFENW a écrit : Show quoted text
> "use base" and "use fields" are very old modules. > 2007 the slim "use parent" was created > that modificates @ISA only. > That is all we need for inheritance. > "use base" is much more. > Please add "use parent" as alternative recommendation.
I agree. And I submitted a patch against Perl::Critic itself to drop most of its usage of "base": https://rt.cpan.org/Ticket/Display.html?id=75300 Note that parent.pm has been created by the Perl 5.10 pumpking, and is in core since 5.10. This is more recent (2007) that the PBP (2005), but shouldn't the policies adapt to the modern times? -- Olivier Mengué - http://perlresume.org/DOLMEN
  Mon May 14 09:32:29 2012 EDAVIS [...] cpan.org - Correspondence added
A bit more background is in this perl core bug report: https://rt.perl.org/rt3//Public/Bug/Display.html?id=112916 It sounds like (a) perlcritic should always recommend 'use parent' and not recommend 'use base', and (b) there could even be a new policy warning about 'use base' and suggesting 'use parent' instead.
  Thu Jul 26 04:17:37 2012 dolmen [...] cpan.org - Reference by ticket #75300 added