Skip Menu |

This queue is for tickets about the HTML-Template-Compiled CPAN distribution.

Maintainer(s)' notes

Note: there is a bug with caching and TMPL_INCLUDE_VAR since 0.97_004 until 0.98. either use an earlier version or upgrade to 0.98_001. Another workaround is to precompile all templates to file_cache_dir. The bug happens when including a template via INCLUDE_VAR and the template is not yet compiled or has changed.

I'm sorry if the change about aliases came quite unannounced. I didn't expect any problems since dollar signs are not allowed in template vars, but I heard from at least one case where people were doing exactly this.
Please do not use unallowed characters in template vars. Allowed are (from the HTML::Template::FAQ): Numbers, letters, '.', '/', '+', '-' and '_'.
This should work in HTML::Template::Compiled::Classic.
in HTML::Template::Compiled you should be only using numbers, letters and _.
The dot, for example, is special. If you need to get a hash key from the template parameters with special charcaters, you can try <tmpl_var _.$var$name$with$dollars >

There will be a workaround in the next version:
local $HTML::Template::Compiled::Compiler::DISABLE_NEW_ALIAS = 1;


Please report any bug you find.
The code is now hosted on https://github.com/perlpunk/HTML-Template-Compiled
If you have a bug report, you can also post it there in the "Issues" section.
In the bugreport, please include, if possible, the module version, perl version and a testcase that reproduces the error; that makes it easier to find the bug.

The issue with not reloading includes of includes should be fixed in version 0.95_003. If you have any problems though please report!

Using query() and the dot syntax might not work together always. If you have a tmpL_var name="..foo" (going up the stash one level) the var foo is not detected and will not be reported by the query() function. Since the dot syntax is for dereferencing hashes and method calls the query function might not make sense anyway. I believe it is a bad idea to let the program do things if the template is using a certain variable.

Thanks!

Report information
The Basics
Id: 70688
Status: resolved
Priority: 0/
Queue: HTML-Template-Compiled

People
Owner: Nobody in particular
Requestors: ken.russell [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.95
Fixed in: 0.97_001



Subject: HTC::Classic crashes when tmpl_var has invalid characters (edge-case)
If #70676 is accepted then this is mute, as a variable can then never be invalid. At the moment if a tmpl_var has a character outside of the accepted range then Classic.pm calls the error_wrong_tag_syntax function with incorrect parameters. I've attached a patch. Love the module (we're currently upgrading from H::T to H::T::C). - Ken
Subject: patch.txt
--- Classic.pm.orig Wed Apr 27 12:10:27 2011 +++ Classic.pm Thu Sep 1 15:19:36 2011 @@ -12,7 +12,12 @@ # only allow '.', '/', '+', '-' and '_' if (!$t->validate_var($args{var})) { $t->get_parser->_error_wrong_tag_syntax( - $context->get_file, $context->get_line, "", $args{var} + { + fname => $context->get_file, + line => $context->get_line, + token => "", + }, + $args{var}, ); } my %loop_context = (
Am Fr 02. Sep 2011, 00:36:28, kenrussell schrieb: Show quoted text
> If #70676 is accepted then this is mute, as a variable can then never
be Show quoted text
> invalid. At the moment if a tmpl_var has a character outside of the > accepted range then Classic.pm calls the error_wrong_tag_syntax
function Show quoted text
> with incorrect parameters. > > I've attached a patch. > > Love the module (we're currently upgrading from H::T to H::T::C). > > - Ken
sorry for the late answer. I fixed it in git (although it shouldn't happen anymore, only if you inherit from it and overwrite the validate_var method). Will be in the next version, 0.97_001 or 0.98 thanks!