Bug #70629 for Devel-DProf: Bleadperl breaks due to static/non-static declarations

Tue Aug 30 22:21:17 2011 ANDK [...] cpan.org - Ticket created

CC:	SMUELLER [...] cpan.org
Subject:	Bleadperl breaks due to static/non-static declarations

/home/sand/src/perl/repoperls/installed-perls/perl/v5.15.2-158-ga62da8e/2b65/bin /perl /home/src/perl/repoperls/installed-perls/perl/v5.15.2-158-ga62da8e/2b65/li b/5.15.2/ExtUtils/xsubpp -typemap /home/src/perl/repoperls/installed-perls/perl /v5.15.2-158-ga62da8e/2b65/lib/5.15.2/ExtUtils/typemap DProf.xs > DProf.xsc && mv DProf.xsc DProf.c Please specify prototyping behavior for DProf.xs (see perlxs manual) cc -c -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LAR GEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -DVERSION=\"20110802.00\" -DXS_VER SION=\"20110802.00\" -fPIC "-I/home/src/perl/repoperls/installed-perls/perl/v5.1 5.2-158-ga62da8e/2b65/lib/5.15.2/x86_64-linux-ld/CORE" DProf.c DProf.c:844:13: error: static declaration of ‘XS_Devel__DProf_END’ follows non-s tatic declaration DProf.xs:107:6: note: previous declaration of ‘XS_Devel__DProf_END’ was here make: *** [DProf.o] Error 1 (/usr/bin/make exited with 512) See also https://rt.cpan.org/Ticket/Display.html?id=70567 Regards,

Fri Oct 14 02:29:10 2011 smueller [...] cpan.org - Correspondence added

I'm not sure whether I've missed Andreas' CC to me or whether it's been lost. Anyway, there was a ticket filed against ExtUtils::ParseXS with the same content. In a nutshell, DProf.xs is doing nasty stuff with implementing XSUBs by hand and this declares them manually with XS(). Since ExtUtils::ParseXS nowadays declares XSUBs with XS_INTERNAL / static, this breaks. There are several ways to fix this, but by far the simplest is at the top of the XS: #define PERL_EUPXS_ALWAYS_EXPORT And all will be well. Working around manually implemented XSUBs in ParseXS is much harder and frankly, DProf has to be rather cozy with internals anyway, so I don't feel too bad about this. --Steffen

Fri Oct 14 02:29:11 2011 The RT System itself - Status changed from 'new' to 'open'

Fri Oct 14 02:35:39 2011 smueller [...] cpan.org - Dependency by ticket #71655 added

Wed Jun 27 11:35:43 2012 ppisar [...] redhat.com - Correspondence added

From:

ppisar [...] redhat.com

Dne Pá 14.říj.2011 02:29:10, SMUELLER napsal(a): Show quoted text

> Since ExtUtils::ParseXS nowadays declares XSUBs with XS_INTERNAL / > static, this breaks. There are several ways to fix this, but by far the > simplest is at the top of the XS: > > #define PERL_EUPXS_ALWAYS_EXPORT > > And all will be well. >

Attached patch implements it.

Subject:

0001-Work-around-static-XS_Devel__DProf_END-mismatch.patch

From 658895c781a8f42752791e4d6f1b32423d1a36f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Wed, 27 Jun 2012 17:18:48 +0200 Subject: [PATCH] Work around static XS_Devel__DProf_END mismatch https://rt.cpan.org/Public/Bug/Display.html?id=70629 --- DProf.xs | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/DProf.xs b/DProf.xs index a4bbb4b..9642010 100644 --- a/DProf.xs +++ b/DProf.xs @@ -1,4 +1,5 @@ #define PERL_NO_GET_CONTEXT +#define PERL_EUPXS_ALWAYS_EXPORT /* Perl 5.16 makes XSUB static, RT #70629 */ #include "EXTERN.h" #include "perl.h" #include "XSUB.h" -- 1.7.7.6

Mon Nov 17 04:51:08 2014 dolmen [...] cpan.org - Correspondence added

RT-Send-CC:

ppisar [...] redhat.com, smueller [...] cpan.org, ether [...] cpan.org

Le 2011-10-14 08:29:10, SMUELLER a écrit :
Show quoted text

> In a nutshell, DProf.xs is doing nasty stuff with implementing XSUBs by
> hand and this declares them manually with XS().
>
> Since ExtUtils::ParseXS nowadays declares XSUBs with XS_INTERNAL /
> static, this breaks. There are several ways to fix this, but by far the
> simplest is at the top of the XS:
>
> #define PERL_EUPXS_ALWAYS_EXPORT
>
> And all will be well.

It would now be helpful to have a CPAN release that includes this patch...

--
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/

Mon Nov 17 05:06:33 2014 dolmen [...] cpan.org - Requestor DOLMEN added

Mon Nov 17 05:08:18 2014 dolmen [...] cpan.org - Dependency by ticket #99329 added

Mon Nov 17 13:53:21 2014 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #70629] Bleadperl breaks due to static/non-static declarations
Date:	Mon, 17 Nov 2014 10:53:10 -0800
To:	Olivier Mengué via RT <bug-Devel-DProf [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Mon, Nov 17, 2014 at 04:51:09AM -0500, Olivier Mengué via RT wrote: Show quoted text

> It would now be helpful to have a CPAN release that includes this patch...

I can do a release if someone wants to give me comaint.