Bug #70604 for Net-DNS-SEC: DS.pm module goes "undefined value" and dies

Tue Aug 30 11:47:36 2011 rayceem [...] rayceem.com - Ticket created

Subject:	DS.pm module goes "undefined value" and dies
Date:	Tue, 30 Aug 2011 17:46:53 +0200
To:	bug-Net-DNS-SEC [...] rt.cpan.org
From:	Einar Lönn <rayceem [...] rayceem.com>

Hi Olaf & other Net::DNS people! :) I beg your pardon for this "nonspecific" bug report but... :( System stats: Perl v5.8.8 Ubuntu 2.6.24-28 Net::DNS::Sec 0.16 When testing dnssec params on domains with "exotic" (as in broken) configurations (happened twice now, but the domains have fixed themselves before I've had the chance to even TRY and reproduce the crash), Net::DNS::Sec exits with: Can't call method "name" on an undefined value at /usr/local/share/perl/5.8.8/Net/DNS/RR/DS.pm line 172. Now, the problem is that this is not reproducable since these domains are in a constant state of change (probably why they use the module to test themselves with DNSCheck). The only thing we know is that we cant really fix this issue easily since it lies within Net::DNS::Sec and not within our own code, we'd be more than happy to see any attempt to fix whatever causes this. ;) Hope you have any ideas, it's quite annoying since I have trouble pinpointing this issue! ;p /Regards, Einar

Download smime.p7s
application/pkcs7-signature 2.1k

Message body not shown because it is not plain text.

Download PGP.sig
application/pgp-signature 194b

Message body not shown because it is not plain text.

Wed Aug 31 10:40:38 2011 willem [...] nlnetlabs.nl - Correspondence added

Subject:	Re: [rt.cpan.org #70604] DS.pm module goes "undefined value" and dies
Date:	Wed, 31 Aug 2011 16:40:14 +0200
To:	bug-Net-DNS-SEC [...] rt.cpan.org
From:	Willem Toorop <willem [...] NLnetLabs.nl>

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Einar, The error occurs when a DS resource record is constructed without (or with a undefined) key object. Either directly, or via Net::DNS::RR::DS::verify . We can fix Net::DNS::RR::DS::verify to return 0 when the key in the argument is undefined, but maybe you might have calls to Net::DNS::RR::DS::create yourself. Something like: ``create Net::DNS::RR::DS($key, ( digtype=> "SHA<something>" ));'' somewhere? I have the check in Net::DNS::RR::DS::verify in revision r889 of net-dns-sec. Regards, Willem On 30-08-11 17:47, Einar Lönn via RT wrote: Show quoted text

> Tue Aug 30 11:47:36 2011: Request 70604 was acted upon. > Transaction: Ticket created by rayceem@rayceem.com > Queue: Net-DNS-SEC > Subject: DS.pm module goes "undefined value" and dies > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: rayceem@rayceem.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=70604 > > > > Hi Olaf & other Net::DNS people! :) > > I beg your pardon for this "nonspecific" bug report but... :( > > System stats: > Perl v5.8.8 > Ubuntu 2.6.24-28 > Net::DNS::Sec 0.16 > > When testing dnssec params on domains with "exotic" (as in broken) configurations (happened twice now, but the domains have fixed themselves before I've had the chance to even TRY and reproduce the crash), Net::DNS::Sec exits with: > Can't call method "name" on an undefined value at /usr/local/share/perl/5.8.8/Net/DNS/RR/DS.pm line 172. > > Now, the problem is that this is not reproducable since these domains are in a constant state of change (probably why they use the module to test themselves with DNSCheck). The only thing we know is that we cant really fix this issue easily since it lies within Net::DNS::Sec and not within our own code, we'd be more than happy to see any attempt to fix whatever causes this. ;) > > Hope you have any ideas, it's quite annoying since I have trouble pinpointing this issue! ;p > > > /Regards, Einar > >

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOXkfOAAoJEOX4+CEvd6SYJE4P/jgj7q6BQ8aJIdDnotd0RxgO glh7cKtOr6zLav7WTevhQQKGpgtcp3qPCfp5Brhpeo1wjP7AyhMpuLFccdmsNKBP WbDjfN3ClJTwvYcUCA3iebL8L45LbSoALmltzpkiL4IcwyDCCRLtAxT6rlErsYad f84tGzdeW5POJAEwKB8+hxumgb4grAivB0v9L1Oroug+7ckRCCXP0TZxnG8ehka+ O0BSC9TSTTHQXHFGCz+kUImUIpZBhPVsrw9WZEbkKaTTM+OHhJ3kVretnrxMuqEo ZPd6u2ZwR9kIFgMCTMZT3A7H//ZbN6jtDclNxhhy2loouMMhWoH6lgytVhklTQLD su1KcfO7j8E0uEq/npTV0P+mb8lr/JPRnnD9gFvgZSyZyKTTXKHiXiz6vdVrVy6o VsbyqWaD/ENIQF/cN3n6/CdYq3oRrWF9w+WTTfJY4ZRn0NFoNTw0LDCAEE2fJLQM bkvB3oY8+stbspFGixgLAjp1dkABYcKOli7RtXA1rwd/simhRmk9SR9vIAKVR3Vm Z6wXE6Sqgg3pGeZBniiL0epXjF+e3GP0OGQ56lXZOzhEZL6Ji+76YUfXZTS9nxxM Ytfjalu6VIgHD4oDDvRRngpsPmseeQ1RFoe00D8gURfshGgWuJnxSGG9m3eikNSl 7zj0ok06tNVjE46jHefi =Ts4W -----END PGP SIGNATURE-----

Wed Aug 31 10:40:40 2011 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 31 10:47:17 2011 willem [...] cpan.org - Correspondence added

Sorry about replying via e-mail without cutting out your details! :( That was clumsy of me.

Thu Sep 01 04:24:48 2011 rayceem [...] rayceem.com - Correspondence added

Subject:	Re: [rt.cpan.org #70604] DS.pm module goes "undefined value" and dies
Date:	Thu, 1 Sep 2011 10:24:02 +0200
To:	bug-Net-DNS-SEC [...] rt.cpan.org
From:	Einar Lönn <rayceem [...] rayceem.com>

On Aug 31, 2011, at 4:40 PM, Willem Toorop via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=70604 > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi Einar, > > The error occurs when a DS resource record is constructed without (or > with a undefined) key object. Either directly, or via > Net::DNS::RR::DS::verify . We can fix Net::DNS::RR::DS::verify to return > 0 when the key in the argument is undefined, but maybe you might have > calls to Net::DNS::RR::DS::create yourself. Something like: > ``create Net::DNS::RR::DS($key, ( digtype=> "SHA<something>" ));'' > somewhere? > > I have the check in Net::DNS::RR::DS::verify in revision r889 of > net-dns-sec. > > Regards, Willem

Hi Willem, Yeah, after gnawing on our code we noticed this too. However, as you said, it's much better if this function fails instead of dies with this patch of yours; thank you! :) We'll patch on our side and hope for a new release of net-dns-sec later on... Thanks again! /Regards, Einar Show quoted text

> On 30-08-11 17:47, Einar Lönn via RT wrote:

>> Tue Aug 30 11:47:36 2011: Request 70604 was acted upon. >> Transaction: Ticket created by rayceem@rayceem.com >> Queue: Net-DNS-SEC >> Subject: DS.pm module goes "undefined value" and dies >> Broken in: (no value) >> Severity: (no value) >> Owner: Nobody >> Requestors: rayceem@rayceem.com >> Status: new >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=70604 > >> >> >> Hi Olaf & other Net::DNS people! :) >> >> I beg your pardon for this "nonspecific" bug report but... :( >> >> System stats: >> Perl v5.8.8 >> Ubuntu 2.6.24-28 >> Net::DNS::Sec 0.16 >> >> When testing dnssec params on domains with "exotic" (as in broken) configurations (happened twice now, but the domains have fixed themselves before I've had the chance to even TRY and reproduce the crash), Net::DNS::Sec exits with: >> Can't call method "name" on an undefined value at /usr/local/share/perl/5.8.8/Net/DNS/RR/DS.pm line 172. >> >> Now, the problem is that this is not reproducable since these domains are in a constant state of change (probably why they use the module to test themselves with DNSCheck). The only thing we know is that we cant really fix this issue easily since it lies within Net::DNS::Sec and not within our own code, we'd be more than happy to see any attempt to fix whatever causes this. ;) >> >> Hope you have any ideas, it's quite annoying since I have trouble pinpointing this issue! ;p >> >> >> /Regards, Einar >> >>

> > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iQIcBAEBAgAGBQJOXkfOAAoJEOX4+CEvd6SYJE4P/jgj7q6BQ8aJIdDnotd0RxgO > glh7cKtOr6zLav7WTevhQQKGpgtcp3qPCfp5Brhpeo1wjP7AyhMpuLFccdmsNKBP > WbDjfN3ClJTwvYcUCA3iebL8L45LbSoALmltzpkiL4IcwyDCCRLtAxT6rlErsYad > f84tGzdeW5POJAEwKB8+hxumgb4grAivB0v9L1Oroug+7ckRCCXP0TZxnG8ehka+ > O0BSC9TSTTHQXHFGCz+kUImUIpZBhPVsrw9WZEbkKaTTM+OHhJ3kVretnrxMuqEo > ZPd6u2ZwR9kIFgMCTMZT3A7H//ZbN6jtDclNxhhy2loouMMhWoH6lgytVhklTQLD > su1KcfO7j8E0uEq/npTV0P+mb8lr/JPRnnD9gFvgZSyZyKTTXKHiXiz6vdVrVy6o > VsbyqWaD/ENIQF/cN3n6/CdYq3oRrWF9w+WTTfJY4ZRn0NFoNTw0LDCAEE2fJLQM > bkvB3oY8+stbspFGixgLAjp1dkABYcKOli7RtXA1rwd/simhRmk9SR9vIAKVR3Vm > Z6wXE6Sqgg3pGeZBniiL0epXjF+e3GP0OGQ56lXZOzhEZL6Ji+76YUfXZTS9nxxM > Ytfjalu6VIgHD4oDDvRRngpsPmseeQ1RFoe00D8gURfshGgWuJnxSGG9m3eikNSl > 7zj0ok06tNVjE46jHefi > =Ts4W > -----END PGP SIGNATURE----- >

Download smime.p7s
application/pkcs7-signature 2.1k

Message body not shown because it is not plain text.

Download PGP.sig
application/pgp-signature 194b

Message body not shown because it is not plain text.

Wed May 02 08:50:17 2012 willem [...] cpan.org - Correspondence added

Cleanup message (was already resolved)

Wed May 02 08:50:23 2012 willem [...] cpan.org - Status changed from 'open' to 'resolved'