Skip Menu |

This queue is for tickets about the B-Hooks-OP-Check CPAN distribution.

Report information
The Basics
Id: 70601
Status: resolved
Priority: 0/
Queue: B-Hooks-OP-Check

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: flora [...] cpan.org
Subject: B:H:O:C hooking protocol
Date: Tue, 30 Aug 2011 13:47:40 +0100
To: bug-B-Hooks-OP-Check [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
B::Hooks::OP::Check doesn't cleanly hook op checkers, because it separates saving the previous checker and installing the new checker. Anything hooking the same checker between these two events gets screwed over. B:H:O:C needs to do both together. Attached patch fixes. Note that the setup() function is no longer required: its Zero()ing is redundant, because static data is guaranteed to be zero-initialised anyway. This module could really do with a test suite. -zefram

Message body is not shown because sender requested not to inline it.

Patch incorporated into B-Hooks-OP-Check-0.19, just released to CPAN.