Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 70456
Status: resolved
Priority: 0/
Queue: Pod-Simple

People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 3.19
Fixed in: 3.28



Subject: Pod::Simple 3.19 requires Test::More 0.88
The use of "done_testing" in t/xhtml15.t means that Test::More 0.88 or later is needed to run the test suite, so either: 1. the version requirement should be specified in META.*/Makefile.PL, or 2. the attached patch could be applied to restore compatibility with ancient Test::More versions
Subject: Pod-Simple-3.19-old-Test::More.patch
--- Pod-Simple-3.19/t/xhtml15.t.orig 2011-08-23 17:18:55.000000000 +0100 +++ Pod-Simple-3.19/t/xhtml15.t 2011-08-24 09:08:32.659887593 +0100 @@ -6,7 +6,7 @@ use strict; use warnings; use lib 'lib'; -use Test::More; +use Test::More tests => 4; use_ok('Pod::Simple::XHTML') or exit; @@ -27,8 +27,6 @@ #note('These methods are called when XHTML is used by HtmlBatch'); can_ok $parser, qw/batch_mode_page_object_init html_header_after_title/; -done_testing; - sub initialize { $parser = Pod::Simple::XHTML->new; $parser->index(1);
On 2011-08-24 04:19:53, paul@city-fan.org wrote: Show quoted text
> The use of "done_testing" in t/xhtml15.t means that Test::More 0.88 or > later is needed to run the test suite, so either: > > 1. the version requirement should be specified in META.*/Makefile.PL, or > > 2. the attached patch could be applied to restore compatibility with > ancient Test::More versions
Oops, thanks. Patch applied. https://github.com/theory/pod- simple/commit/25e952f42af6fe49d4bc08373da3826132b6f4b1 David
From: paul [...] city-fan.org
On Wed Aug 24 12:29:19 2011, DWHEELER wrote: Show quoted text
> On 2011-08-24 04:19:53, paul@city-fan.org wrote:
> > The use of "done_testing" in t/xhtml15.t means that Test::More 0.88 or > > later is needed to run the test suite, so either: > > > > 1. the version requirement should be specified in META.*/Makefile.PL, or > > > > 2. the attached patch could be applied to restore compatibility with > > ancient Test::More versions
> > Oops, thanks. Patch applied.
Similar problem re-introduced in 3.27. Patch attached.
Subject: Pod-Simple-3.27-old-Test::More.patch
--- t/whine.t +++ t/whine.t @@ -1,6 +1,6 @@ use strict; use warnings; -use Test::More; +use Test::More tests => 4; { package Pod::Simple::ErrorFinder; @@ -68,4 +68,3 @@ ); } -done_testing;
Subject: Re: [rt.cpan.org #70456] Pod::Simple 3.19 requires Test::More 0.88
Date: Fri, 3 May 2013 11:57:18 -0700
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <david [...] justatheory.com>
On May 3, 2013, at 11:43 AM, "paul@city-fan.org via RT" <bug-Pod-Simple@rt.cpan.org> wrote: Show quoted text
> Similar problem re-introduced in 3.27. Patch attached.
Gah! Thanks, patch applied. https://github.com/theory/pod-simple/commit/3cdc3112348588d697803261abf163962e37a7cc