Skip Menu |

This queue is for tickets about the Classic-Perl CPAN distribution.

Report information
The Basics
Id: 70415
Status: resolved
Priority: 0/
Queue: Classic-Perl
People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.02a
Fixed in: (no value)

History Show all quoted text
  Mon Aug 22 08:55:58 2011 ppisar [...] redhat.com - Ticket created
Subject: Useless requires: Test::More
META.yml states: requires: [...] Test::More: 0 however I cannot find any use of Test::More from the module except tests itself. I think the statement is superfluous and should be removed.
  Mon Aug 29 00:12:08 2011 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Mon Aug 22 08:55:58 2011, ppisar wrote: Show quoted text
> META.yml states: > > requires: > [...] > Test::More: 0 > > however I cannot find any use of Test::More from the module except tests > itself. I think the statement is superfluous and should be removed.
That file is generated automatically by ExtUtils::MakeMaker. Do you know of any way to customise it (without switching build modules)?
  Mon Aug 29 00:12:09 2011 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 29 03:38:06 2011 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #70415] Useless requires: Test::More
Date: Mon, 29 Aug 2011 09:37:53 +0200
To: Father Chrysostomos via RT <bug-Classic-Perl [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Mon, Aug 29, 2011 at 12:12:08AM -0400, Father Chrysostomos via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=70415 > > > On Mon Aug 22 08:55:58 2011, ppisar wrote:
> > META.yml states: > > > > requires: > > [...] > > Test::More: 0 > > > > however I cannot find any use of Test::More from the module except tests > > itself. I think the statement is superfluous and should be removed.
> > That file is generated automatically by ExtUtils::MakeMaker. Do you know of > any way to customise it (without switching build modules)? >
diff --git a/Makefile.PL b/Makefile.PL index 5278f06..d5778ca 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -30,7 +30,6 @@ WriteMakefile( XS_VERSION => '0.02', ABSTRACT_FROM => 'lib/Classic/Perl.pm', PREREQ_PM => { - Test'More => 0, $]>5.0089999 ? ( 'XSLoader' => 0, ) : (), -- Petr
Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

  Mon Aug 29 16:50:18 2011 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Mon Aug 29 03:38:06 2011, ppisar wrote: Show quoted text
> On Mon, Aug 29, 2011 at 12:12:08AM -0400, Father Chrysostomos via RT > wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=70415 > > > > > On Mon Aug 22 08:55:58 2011, ppisar wrote:
> > > META.yml states: > > > > > > requires: > > > [...] > > > Test::More: 0 > > > > > > however I cannot find any use of Test::More from the module except
> tests
> > > itself. I think the statement is superfluous and should be
> removed.
> > > > That file is generated automatically by ExtUtils::MakeMaker. Do you
> know of
> > any way to customise it (without switching build modules)? > >
> > diff --git a/Makefile.PL b/Makefile.PL > index 5278f06..d5778ca 100644 > --- a/Makefile.PL > +++ b/Makefile.PL > @@ -30,7 +30,6 @@ WriteMakefile( > XS_VERSION => '0.02', > ABSTRACT_FROM => 'lib/Classic/Perl.pm', > PREREQ_PM => { > - Test'More => 0, > $]>5.0089999 ? ( > 'XSLoader' => 0, > ) : (),
But that will cause it to fail its tests on Perl 5.6. :-(
  Sat Sep 10 04:56:42 2011 zefram [...] fysh.org - Correspondence added
Subject: Re: [rt.cpan.org #70415] Useless requires: Test::More
Date: Sat, 10 Sep 2011 09:56:25 +0100
To: bug-Classic-Perl [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
The declaration is not superfluous, since Test::More is actually required in order to pass the test suite. -zefram
  Sun Sep 11 17:44:14 2011 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Status changed from 'open' to 'rejected'
  Mon Sep 12 03:44:07 2011 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #70415] Useless requires: Test::More
Date: Mon, 12 Sep 2011 09:43:53 +0200
To: Zefram via RT <bug-Classic-Perl [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Sat, Sep 10, 2011 at 04:56:44AM -0400, Zefram via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=70415 > > > The declaration is not superfluous, since Test::More is actually required > in order to pass the test suite. >
The test-time dependencies are already expressed by build_requires: build_requires => { 'ExtUtils::MakeMaker' => 0, 'Test::More' => 0, }, having Test::More in both hashes is superfluous (except in case of Perl 5.6). -- Petr
Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

  Mon Sep 12 03:44:08 2011 The RT System itself - Status changed from 'rejected' to 'open'
  Sun Sep 18 19:59:30 2011 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Mon Sep 12 03:44:07 2011, ppisar wrote: Show quoted text
> On Sat, Sep 10, 2011 at 04:56:44AM -0400, Zefram via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=70415 > > > > > The declaration is not superfluous, since Test::More is actually
> required
> > in order to pass the test suite. > >
> The test-time dependencies are already expressed by build_requires: > > build_requires => { > 'ExtUtils::MakeMaker' => 0, > 'Test::More' => 0, > }, > > having Test::More in both hashes is superfluous (except in case of > Perl 5.6).
Thank you. I’d forgotten about that. I’ve fixed it in version 0.03.
  Sun Sep 18 19:59:30 2011 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Status changed from 'open' to 'resolved'