Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the devel-nytprof CPAN distribution.

Report information
The Basics
Id: 70207
Status: resolved
Priority: 0/
Queue: devel-nytprof
People
Owner: Nobody in particular
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 4.06
Fixed in: (no value)

History Show all quoted text
  Thu Aug 11 03:33:58 2011 HMBRAND [...] cpan.org - Ticket created
Subject: nytprofhtml generates invalid html
A redundant </span> tag is generated causing parse errors --8<--- error in Opera-12.00 XML parsing failed XML parsing failed: syntax error (Line: 129, Character: 324) Reparse document as HTML -->8--- $ perl -ne'129..129 and print' nytprof/JSON-PP-pm-135-line.html <tr><td class="c0">5688334</td><td class="c0">15</td><td class="c3">1</td><td class="c0"><span title="0.0%">172s</span></ Show quoted text
td><td class="c0"><span title="0.0%">172s</span></td><td
class="sub_name"><span style="display: none;">JSON::PP::::next_chr</ Show quoted text
span> JSON::PP::<a href="JSON-PP-pm-135-
line.html#717">next_chr</a></span></td></tr> The last </span> on that line has no opening <span>
  Thu Aug 11 06:29:27 2011 HMBRAND [...] cpan.org - Correspondence added
Here's the patch: --8<--- --- bin/nytprofhtml.org 2011-08-11 12:27:01.000000000 +0200 +++ bin/nytprofhtml 2011-08-11 12:27:47.000000000 +0200 @@ -357,7 +357,7 @@ sub subroutine_table { $recdepth, fmt_time($sub->recur_incl_time); } - $sub_links .= sprintf qq{%*s<a %s>%s</a>%s</span></td>}, + $sub_links .= sprintf qq{%*s<a %s>%s</a>%s</td>}, $max_pkg_name_len+2, $pkg, $reporter->href_for_sub($subname), $subr, -->8---
  Thu Aug 11 06:29:28 2011 HMBRAND [...] cpan.org - Status changed from 'new' to 'open'
  Mon Jan 02 15:46:32 2012 TIMB [...] cpan.org - Correspondence added
Patched in r1410. Thanks.
  Mon Jan 02 15:46:33 2012 TIMB [...] cpan.org - Status changed from 'open' to 'resolved'