Skip Menu |

This queue is for tickets about the Email-Send-SMTP-TLS CPAN distribution.

Report information
The Basics
Id: 70178
Status: open
Priority: 0/
Queue: Email-Send-SMTP-TLS

People
Owner: Nobody in particular
Requestors: lpsolit [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Use the same list of arguments as Email::Send::SMTP
Date: Wed, 10 Aug 2011 01:03:09 +0200
To: bug-Email-Send-SMTP-TLS [...] rt.cpan.org
From: "Frédéric Buclin" <lpsolit [...] gmail.com>
Email::Send::SMTP uses username and password as arguments. Email::Send::SMTP::TLS uses User and Password. Please use the same arguments as Email::Send::SMTP for compatibility, and to make us write code more easily when using both modules. If you don't want to break backward compatibility, you could map the old names to the new ones. Historical background: https://bugzilla.mozilla.org/show_bug.cgi?id=466419#c14
from the source of the Email::Send::SMTP my ($user, $pass) = @args{qw[username password]}; if ( $user ) { $SMTP->auth($user, $pass) or return failure "Couldn't authenticate '$user:...'"; } I can add something like below to support the code. ### for https://rt.cpan.org/Ticket/Display.html?id=70178 sub auth { my ($me, $username, $password) = @_; $me->{User} = $username; $me->{Password} = $password; $me->login(); } but you should be noticed there is a lot of difference between the module and the Net::SMTP. the login will croak if failed. and I couldn't change it because of compatibility. any thoughts? Thanks On Tue Aug 09 19:03:22 2011, lpsolit@gmail.com wrote: Show quoted text
> Email::Send::SMTP uses username and password as arguments. > Email::Send::SMTP::TLS uses User and Password. > > Please use the same arguments as Email::Send::SMTP for compatibility, > and to make us write code more easily when using both modules. If you > don't want to break backward compatibility, you could map the old
names Show quoted text
> to the new ones. > > Historical background: > https://bugzilla.mozilla.org/show_bug.cgi?id=466419#c14