On 2011-08-04 00:56:15, DUMB wrote:
Show quoted text> If a track name (maybe artist too) contains more than one space the
> lyrics are not fetched.
This seems odd to me - the test script requests "Cast No Shadow" by
Oasis, that contains more than one space so that should have triggered
the bug.
Show quoted text> Also & signs need encoding to %26, haven't come
> across any others that need encoding yet.
Yeah, that makes sense - I'll make use of URI::Escape to handle it, I
think, so I know it's all done correctly.
Show quoted text> As a fix:
>
> lyricwiki.pm: line 68
>
> my $url = join ':', map { s/\s+/_/g; $_ } ($artist, $song);
That looks like a sane change; I'll want to see the test suite fail on
artists/titles with multiple spaces first, then verify that that change
fixes it. Hopefully I'll get a chance to do that tonight, then get a
new version out.
Cheers!
