Bug #69946 for FCGI-ProcManager: start_delay parameter causes FCGI::ProcManager to hang (patch to solve included)

> Mon Aug 01 16:20:21 2011: Request 69946 was acted upon. > Transaction: Ticket created by dark_neo@Safe-mail.net > Queue: FCGI-ProcManager > Subject: start_delay parameter causes FCGI::ProcManager to hang (patch to solve included) > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dark_neo@Safe-mail.net > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=69946 > > > > Hi, > > Tried to use start_delay parameter for making FCGI::ProcManager ver. 0.19 to not restart dying children too often, like this: > > pm_manage(n_processes => 2, start_delay => 2, die_timeout => 30); > > and found that now it starts only one child and hangs. Looking at source revealed: > > for (my $s = $this->start_delay(); $s; $s = sleep $s) {}; > > This is perl, v5.10.1, and perldoc -f sleep says: > > sleep Causes the script to sleep for EXPR seconds, or forever if no > EXPR. Returns the number of seconds actually slept. > > So obviously this is an infinite loop. Here is a patch to solve: > > --- ProcManager.pm~ 2011-08-02 03:04:09.000000000 +0000 > +++ ProcManager.pm 2011-08-02 03:04:58.000000000 +0000 > @@ -228,7 +228,7 @@ > last MANAGING_LOOP; > } > > - for (my $s = $this->start_delay(); $s; $s = sleep $s) {}; > + for (my $s = $this->start_delay(); $s > 0; $s -= sleep $s) {}; > } > > # this should block until the next server dies. > > Please fix... > > differences between files attachment (ProcManager.pm.patch) > --- ProcManager.pm~ 2011-08-02 03:04:09.000000000 +0000 > +++ ProcManager.pm 2011-08-02 03:04:58.000000000 +0000 > @@ -228,7 +228,7 @@ > last MANAGING_LOOP; > } > > - for (my $s = $this->start_delay(); $s; $s = sleep $s) {}; > + for (my $s = $this->start_delay(); $s > 0; $s -= sleep $s) {}; > } > > # this should block until the next server dies.