Skip Menu |

This queue is for tickets about the Method-Signatures-Simple CPAN distribution.

Report information
The Basics
Id: 69909
Status: resolved
Priority: 0/
Queue: Method-Signatures-Simple
People
Owner: Nobody in particular
Requestors: ANNO [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: 1.01
Attachments
patch

History Show all quoted text
  Sat Jul 30 18:15:12 2011 ANNO [...] cpan.org - Ticket created
Subject: Allow declaration of non-methods (feature request)
I'd like to add the ability do declare the occasional non-method using signature syntax. The attached patch enables this by allowing a boolean false value for the "invocant" option of the import method, for example use Method::Signatures::Simple invocant => 0, name => 'nonmeth'; The modified parse_proto handles this case by not inserting invocant code. As is, the patch only adds the functionality. If you approve I can add tests (it passes the current ones) and doc changes. I think an example in the synopsis would be in order if it goes in. My motivation isn't just the "occasional non-method" in OO modules. I routinely use MSS for OO projects. With the change, I'd be able to use it for non-OO too.
Subject: patch
Download patch
application/octet-stream 709b

Message body not shown because it is not plain text.

  Thu Aug 25 13:16:15 2011 chip [...] pobox.com - Correspondence added
From: chip [...] pobox.com
On Sat Jul 30 18:15:12 2011, ANNO wrote: Show quoted text
> I'd like to add the ability do declare the occasional non-method using > signature syntax.
As it happens, so I would I, and I wrote a patch for it too: https://github.com/chipdude/method-signatures- simple/commit/24928a4ebbfa903c9a807bc5298a3085595243fa My change goes further by installing a "func" keyword by default, but it seems like a really good feature either way.
  Thu Aug 25 13:16:17 2011 The RT System itself - Status changed from 'new' to 'open'
  Thu Aug 25 13:27:11 2011 chip [...] pobox.com - Correspondence added
From: chip [...] pobox.com
On Thu Aug 25 13:16:15 2011, CHIPS wrote: Show quoted text
> On Sat Jul 30 18:15:12 2011, ANNO wrote:
> > I'd like to add the ability do declare the occasional non-method using > > signature syntax.
> > As it happens, so I would I, and I wrote a patch for it too: > > https://github.com/chipdude/method-signatures-
simple/commit/24928a4ebbfa903c9a807bc5298a3085595243fa RT seems to break this long link, so try: http://goo.gl/96QCv
  Sat Aug 27 19:20:04 2011 anno5 [...] mac.com - Correspondence added
CC: ANNO [...] cpan.org
Subject: Re: [rt.cpan.org #69909] Allow declaration of non-methods (feature request)
Date: Sun, 28 Aug 2011 01:19:06 +0200
To: bug-Method-Signatures-Simple [...] rt.cpan.org
From: Anno Siegel <anno5 [...] mac.com>
On 25.08.2011, at 19:27, Chip Salzenberg via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=69909 > > > On Thu Aug 25 13:16:15 2011, CHIPS wrote:
>> On Sat Jul 30 18:15:12 2011, ANNO wrote:
>>> I'd like to add the ability do declare the occasional non-method using >>> signature syntax.
>> >> As it happens, so I would I, and I wrote a patch for it too: >> >> https://github.com/chipdude/method-signatures-
> simple/commit/24928a4ebbfa903c9a807bc5298a3085595243fa > > RT seems to break this long link, so try: http://goo.gl/96QCv
Thanks, very nice. It's just what I had in mind, but you elaborated what I only promised.
  Fri Aug 31 09:23:47 2012 rhesa [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Aug 31 09:23:48 2012 rhesa [...] cpan.org - Fixed in 1.01 added