Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Inline CPAN distribution.

Report information
The Basics
Id: 69884
Status: resolved
Priority: 0/
Queue: Inline

People
Owner: Nobody in particular
Requestors: nine [...] detonation.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Require newer Digest::MD5
Please upgrade the Digest::MD5 requirements to at least version 2.50. After a year of trying to find out why a certain test of Inline::Python failes on many machines, I finally tracked it down to different Digest::MD5 versions being installed. Versions < 2.50 do not preserve UTF-8-ness of the arguments but downgrade them. This is why for me UTF-8 encoded Python code never gave a problem, because Python never saw it. When I found out that I had to tell the Python interpreter that the code was in UTF- 8, it suddenly broke for me until I moved down the "use utf8;" in the test file to below the Python code. I just added the requirement of Digest::MD5 >= 2.50 to Inline::Python, but since I'm not the one using this module and there may be other Inline modules having similar problems, it should be added to Inline itself.
RT-Send-CC: nine [...] detonation.org, ingy [...] ingy.net
On Fri Jul 29 10:21:14 2011, NINE wrote: Show quoted text
> Please upgrade the Digest::MD5 requirements to at least version 2.50. > After a year of > trying to find out why a certain test of Inline::Python failes on many > machines, I finally > tracked it down to different Digest::MD5 versions being installed. > > Versions < 2.50 do not preserve UTF-8-ness of the arguments but > downgrade them. This > is why for me UTF-8 encoded Python code never gave a problem, because > Python never > saw it. When I found out that I had to tell the Python interpreter > that the code was in UTF- > 8, it suddenly broke for me until I moved down the "use utf8;" in the > test file to below the > Python code. > > I just added the requirement of Digest::MD5 >= 2.50 to Inline::Python, > but since I'm not > the one using this module and there may be other Inline modules having > similar problems, > it should be added to Inline itself.
Hi, cc'ing Ingy in case he has any thoughts about this. Strictly speaking, if Inline modules (other than Inline itself or Inline::C) have similar problems then *they* should take the same action as you have taken wrt Inline::Python. If neither Inline nor Inline::C are affected, then there's no need (again, "strictly speaking") for Inline to do anything about it. However, if you could provide a simple test case that shows that either Inline or Inline::C is affected, then that might force my hand :-) In any case, I'll consider doing as you suggest. (It's the flow-on affects that deter me - eg since Digest::MD5-2.50 requires perl-5.8, Inline could no longer support perl-5.6, so there are some additional amendments that might need to be made. I don't really want to be doing stuff that's unnecessary ... otoh it's probably time that Inline stopped supporting 5.6 anyway.) Thanks for raising this. Cheers, Rob
RT-Send-CC: ingy [...] ingy.net, nine [...] detonation.org
On Fri Jul 29 10:21:14 2011, NINE wrote: Show quoted text
> Please upgrade the Digest::MD5 requirements to at least version 2.50. > After a year of > trying to find out why a certain test of Inline::Python failes on many > machines, I finally > tracked it down to different Digest::MD5 versions being installed. > > Versions < 2.50 do not preserve UTF-8-ness of the arguments but > downgrade them. This > is why for me UTF-8 encoded Python code never gave a problem, because > Python never > saw it. When I found out that I had to tell the Python interpreter > that the code was in UTF- > 8, it suddenly broke for me until I moved down the "use utf8;" in the > test file to below the > Python code. > > I just added the requirement of Digest::MD5 >= 2.50 to Inline::Python, > but since I'm not > the one using this module and there may be other Inline modules having > similar problems, > it should be added to Inline itself.
Try again ... see if it formats ok this time ... otherwise give up trying. Hi, cc'ing Ingy in case he has any thoughts about this. Strictly speaking, if Inline modules (other than Inline itself or Inline::C) have similar problems then *they* should take the same action as you have taken wrt Inline::Python. If neither Inline nor Inline::C are affected, then there's no need (again, "strictly speaking") for Inline to do anything about it. However, if you could provide a simple test case that shows that either Inline or Inline::C is affected, then that might force my hand :-) In any case, I'll consider doing as you suggest. (It's the flow-on affects that deter me - eg since Digest::MD5-2.50 requires perl-5.8, Inline could no longer support perl-5.6, so there are some additional amendments that might need to be made. I don't really want to be doing stuff that's unnecessary ... otoh it's probably time that Inline stopped supporting 5.6 anyway.) Thanks for raising this. Cheers, Rob
Lack of follow-up.
I was unable to create a testcase with Inline::C but I've never used Inline::C before, so it may not mean much. Anyway, including Digest::MD5 2.50 as dependency for Inline::Python fixed the problem for me. I guess other Inline users never stumbled over this.
On Tue Jun 24 06:57:28 2014, NINE wrote: Show quoted text
> I was unable to create a testcase with Inline::C
That's ok, Stefan ... it's just that I was closing some bug reports for issues that had been fixed, and decided I would also close the various tickets that had been sitting idle for a time, and going nowhere. Cheers, Rob