Bug #69811 for MooseX-Storage: No need to depend on Digest::SHA1

Tue Jul 26 04:57:05 2011 CARNIL [...] cpan.org - Ticket created

Subject:	No need to depend on Digest::SHA1
Date:	Tue, 26 Jul 2011 10:56:54 +0200
To:	bug-MooseX-Storage [...] rt.cpan.org
From:	Salvatore Bonaccorso <carnil [...] cpan.org>

Hi Digest::HMAC changed to use not anymore Digest::SHA1. MooseX::Storage was depending on Digest::SHA1 for Digest::HMAC? I cannot find any reference in the code which uses directly Digest::SHA1. If I'm correctly, could you drop the dependency on Digest::SHA1? Digest::SHA is in perl core since 5.9.3 and it has quite identical interface as Digest::SHA1, it defaults to SHA1 and furthermore this would be reducing the external dependencies by one. Could you apply this change? Regards Salvatore

Mon Aug 15 15:43:52 2011 carnil [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #69811] AutoReply: No need to depend on Digest::SHA1
Date:	Mon, 15 Aug 2011 21:43:41 +0200
To:	Bugs in MooseX-Storage via RT <bug-MooseX-Storage [...] rt.cpan.org>
From:	Salvatore Bonaccorso <carnil [...] debian.org>

Hi Here is a possible patch for this. It simply substitutes the algorithm name with SHA-1. Regards Salvatore

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Mon Aug 15 15:43:55 2011 The RT System itself - Status changed from 'new' to 'open'

Sat May 05 10:27:00 2012 bobtfish [...] bobtfish.net - Correspondence added

Applied in commit 7d5ab5, will be in the next release. Thanks for the patch!

Sat May 05 10:27:03 2012 bobtfish [...] bobtfish.net - Status changed from 'open' to 'resolved'