Skip Menu |

This queue is for tickets about the Mail-Box CPAN distribution.

Report information
The Basics
Id: 69803
Status: resolved
Priority: 0/
Queue: Mail-Box
People
Owner: Nobody in particular
Requestors: christoph.weber [...] das-mehdorn.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jul 25 19:17:35 2011 christoph.weber [...] das-mehdorn.de - Ticket created
Subject: Broken Message-ID generation in Mail/Message/Head/Complete.pm
Date: Tue, 26 Jul 2011 01:17:02 +0200
To: bug-Mail-Box [...] rt.cpan.org
From: Christoph 'Mehdorn' Weber <christoph.weber [...] das-mehdorn.de>
Hi! I believe the Message-ID generator in Mail/Message/Head/Complete.pm is broken, because Sys::Hostname is used and will usually give you only the short name of the box. However, RFC 5322 recommends the usage of a domain name (in section 3.6.4): "it is RECOMMENDED that the right-hand side contain some domain identifier (either of the host itself or otherwise)" I therefore suggest using hostfqdn() from Net::Domain instead of Sys::Hostname's hostname(). Or, at least, try to use Net::Domain and fall back to Sys::Hostname if you can't get an FQDN out of hostfqdn(). Sincerly, Christoph
  Tue Jul 26 12:55:35 2011 Mark [...] Overmeer.net - Correspondence added
Subject: Re: [rt.cpan.org #69803] Broken Message-ID generation in Mail/Message/Head/Complete.pm
Date: Tue, 26 Jul 2011 18:55:17 +0200
To: Christoph 'Mehdorn' Weber via RT <bug-Mail-Box [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* Christoph 'Mehdorn' Weber via RT (bug-Mail-Box@rt.cpan.org) [110725 23:17]: Show quoted text
> Mon Jul 25 19:17:35 2011: Request 69803 was acted upon. > Transaction: Ticket created by christoph.weber@das-mehdorn.de > Queue: Mail-Box > Subject: Broken Message-ID generation in Mail/Message/Head/Complete.pm > Requestors: christoph.weber@das-mehdorn.de > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=69803 > > > I believe the Message-ID generator in > Mail/Message/Head/Complete.pm is broken,
... Show quoted text
> "it is RECOMMENDED that the right-hand side contain some domain > identifier (either of the host itself or otherwise)"
When the implementation is not conform a recommendation, the code is not broken but sub-optimal. But, besides this nagging (which you should ignore), you have a point. The hostname produced by Sys::Hostname::hostname() is not always fully qualified. Depends on your OS (=linux distribution) Net::Domain may do a better job. I'll evaluate that after my holidays. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions drs Mark A.C.J. Overmeer MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Tue Jul 26 12:55:36 2011 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 01 15:42:51 2011 Mark [...] Overmeer.net - Correspondence added
Subject: Re: [rt.cpan.org #69803] Broken Message-ID generation in Mail/Message/Head/Complete.pm
Date: Mon, 1 Aug 2011 21:42:34 +0200
To: Christoph 'Mehdorn' Weber via RT <bug-Mail-Box [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* Christoph 'Mehdorn' Weber via RT (bug-Mail-Box@rt.cpan.org) [110725 23:17]: Show quoted text
> Mon Jul 25 19:17:35 2011: Request 69803 was acted upon. > Transaction: Ticket created by christoph.weber@das-mehdorn.de > Subject: Broken Message-ID generation in Mail/Message/Head/Complete.pm > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=69803 > > > I therefore suggest using hostfqdn() from Net::Domain instead of > Sys::Hostname's hostname(). Or, at least, try to use Net::Domain > and fall back to Sys::Hostname if you can't get an FQDN out of > hostfqdn().
I take the latter choice, to avoid an extra dependency. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Tue Nov 22 10:45:56 2011 MARKOV [...] cpan.org - Correspondence added
Pixed in 2.101 (released aug 25)
  Tue Nov 22 10:45:57 2011 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'