Skip Menu |

This queue is for tickets about the CPAN-Site CPAN distribution.

Report information
The Basics
Id: 69692
Status: resolved
Priority: 0/
Queue: CPAN-Site

People
Owner: Nobody in particular
Requestors: b.jakubski [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.08
Fixed in: (no value)



Subject: cpansite does not process zip archives
I have no idea if this should be supported, but while preparing private CPAN with some older CPAN modules I found that for example http://search.cpan.org/~chorny/Test-Warn-0.21/ was distributed as a .zip file, which CPAN::Site did not notice.
Subject: Re: [rt.cpan.org #69692] cpansite does not process zip archives
Date: Wed, 3 Aug 2011 16:55:32 +0200
To: "http://migo.myopenid.com/ via RT" <bug-CPAN-Site [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* http://migo.myopenid.com/ via RT (bug-CPAN-Site@rt.cpan.org) [110722 17:35]: Show quoted text
> Fri Jul 22 10:07:00 2011: Request 69692 was acted upon. > Transaction: Ticket created by http://migo.myopenid.com/ > Queue: CPAN-Site > Subject: cpansite does not process zip archives > Broken in: 1.08
I have been on holidays Show quoted text
> I have no idea if this should be supported, but while preparing private CPAN with some older CPAN > modules I found that for example http://search.cpan.org/~chorny/Test-Warn-0.21/ was distributed as a > .zip file, which CPAN::Site did not notice.
It should be supported, yes, although very rare: no common tools produces these files by default. Find attached my first (totally untested) attempt. Can you test it for me? -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
Download CPAN-Site-1.09.tar.gz
application/x-tar-gz 69.6k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #69692] cpansite does not process zip archives
Date: Wed, 3 Aug 2011 23:32:43 +0200
To: bug-CPAN-Site [...] rt.cpan.org
From: Bartosz Jakubski <b.jakubski [...] gmail.com>
On Wed, Aug 3, 2011 at 16:55, Mark Overmeer via RT <bug-CPAN-Site@rt.cpan.org> wrote: Show quoted text
>> I have no idea if this should be supported, but while preparing private CPAN with some older CPAN >> modules I found that for example http://search.cpan.org/~chorny/Test-Warn-0.21/ was distributed as a >> .zip file, which CPAN::Site did not notice.
> > It should be supported, yes, although very rare: no common tools produces > these files by default.  Find attached my first (totally untested) > attempt. Can you test it for me?
Quick test (with Test-Warn 0.21) says it is not working. I may have more time tomorrow to have a look at it in more detail. (BTW: this experimental CPAN::Site did not declare Archive::Zip as a prequisite) -- -- Bartosz Jakubski -------------------
Subject: Re: [rt.cpan.org #69692] cpansite does not process zip archives
Date: Thu, 4 Aug 2011 10:19:09 +0200
To: bug-CPAN-Site [...] rt.cpan.org
From: Bartosz Jakubski <b.jakubski [...] gmail.com>
On Wed, Aug 3, 2011 at 23:32, Bartosz Jakubski <b.jakubski@gmail.com> wrote: Show quoted text
> On Wed, Aug 3, 2011 at 16:55, Mark Overmeer via RT > <bug-CPAN-Site@rt.cpan.org> wrote: >
>>> I have no idea if this should be supported, but while preparing private CPAN with some older CPAN >>> modules I found that for example http://search.cpan.org/~chorny/Test-Warn-0.21/ was distributed as a >>> .zip file, which CPAN::Site did not notice.
>> >> It should be supported, yes, although very rare: no common tools produces >> these files by default.  Find attached my first (totally untested) >> attempt. Can you test it for me?
> > Quick test (with Test-Warn 0.21) says it is not working. > I may have more time tomorrow to have a look at it in more detail. >
After patching: 1. $zip regex needs 'x' modifier added 2. Don't try using $member->externalFileName as file name, as (at least in that Test-Warn zip) it returns _zip file_ filepath, not a member filepath it seems to work. -- -- Bartosz Jakubski -------------------
Subject: Re: [rt.cpan.org #69692] cpansite does not process zip archives
Date: Thu, 4 Aug 2011 10:22:35 +0200
To: "b.jakubski [...] gmail.com via RT" <bug-CPAN-Site [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* b.jakubski@gmail.com via RT (bug-CPAN-Site@rt.cpan.org) [110804 08:19]: Show quoted text
> it seems to work.
I'll release it now as version 1.09. Will take up to a day before it reaches the mirrors. -- Thanks, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
implemented in 1.09, release august 2011