Skip Menu |

This queue is for tickets about the Net-OpenID-Server CPAN distribution.

Report information
The Basics
Id: 69651
Status: open
Priority: 0/
Queue: Net-OpenID-Server
People
Owner: Nobody in particular
Requestors: peter [...] vereshagin.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.030099_002

History Show all quoted text
  Thu Jul 21 07:38:06 2011 https://peter.vereshagin.org/ - Ticket #69650: Ticket created
Trying this RP software with NOS: http://framework.zend.com/manual/en/zend.openid.html In certain condition ( unworkable DH parameters from php's openssl extension avoids from DH's g and p parameters to be read from key resource handle ) the diagnostics is unclear on RP side. Consumer class requires the association type to be returned or it can not diagnose such a situation.
Subject: nos-assoc.patch
diff -ur Net-OpenID-Server-1.030099_002.orig/lib/Net/OpenID/Server.pm Net-OpenID-Server-1.030099_002/lib/Net/OpenID/Server.pm --- Net-OpenID-Server-1.030099_002.orig/lib/Net/OpenID/Server.pm 2011-01-01 04:55:00.000000000 +0300 +++ Net-OpenID-Server-1.030099_002/lib/Net/OpenID/Server.pm 2011-06-30 19:05:38.000000000 +0400 @@ -594,10 +594,12 @@ my $p = OpenID::util::arg2int($self->args("openid.dh_modulus")); my $g = OpenID::util::arg2int($self->args("openid.dh_gen")); my $cpub = OpenID::util::arg2int($self->args("openid.dh_consumer_public")); + my $asct = $self->args("openid.assoc_type"); my $dh = OpenID::util::get_dh($p, $g); - return $self->_error_page("invalid dh params p=$p, g=$g, cpub=$cpub") - unless $dh and $cpub; + return $self->_error_page("invalid dh params p=$p, g=$g, cpub=$cpub" + . "\nassoc_type:$asct" + ) unless $dh and $cpub; my $dh_sec = $dh->compute_secret($cpub); @@ -1152,4 +1154,4 @@ =head1 AUTHORS -Brad Fitzpatrick <brad@danga.com> \ No newline at end of file +Brad Fitzpatrick <brad@danga.com>
  Thu Jul 21 07:38:38 2011 https://peter.vereshagin.org/ - Ticket created
Subject: association type return when wrong DH parameters
Trying this RP software with NOS: http://framework.zend.com/manual/en/zend.openid.html In certain condition ( unworkable DH parameters from php's openssl extension avoids from DH's g and p parameters to be read from key resource handle ) the diagnostics is unclear on RP side. Consumer class requires the association type to be returned or it can not diagnose such a situation.
Subject: nos-assoc.patch
diff -ur Net-OpenID-Server-1.030099_002.orig/lib/Net/OpenID/Server.pm Net-OpenID-Server-1.030099_002/lib/Net/OpenID/Server.pm --- Net-OpenID-Server-1.030099_002.orig/lib/Net/OpenID/Server.pm 2011-01-01 04:55:00.000000000 +0300 +++ Net-OpenID-Server-1.030099_002/lib/Net/OpenID/Server.pm 2011-06-30 19:05:38.000000000 +0400 @@ -594,10 +594,12 @@ my $p = OpenID::util::arg2int($self->args("openid.dh_modulus")); my $g = OpenID::util::arg2int($self->args("openid.dh_gen")); my $cpub = OpenID::util::arg2int($self->args("openid.dh_consumer_public")); + my $asct = $self->args("openid.assoc_type"); my $dh = OpenID::util::get_dh($p, $g); - return $self->_error_page("invalid dh params p=$p, g=$g, cpub=$cpub") - unless $dh and $cpub; + return $self->_error_page("invalid dh params p=$p, g=$g, cpub=$cpub" + . "\nassoc_type:$asct" + ) unless $dh and $cpub; my $dh_sec = $dh->compute_secret($cpub); @@ -1152,4 +1154,4 @@ =head1 AUTHORS -Brad Fitzpatrick <brad@danga.com> \ No newline at end of file +Brad Fitzpatrick <brad@danga.com>
  Thu Jul 21 07:46:58 2011 https://peter.vereshagin.org/ - Ticket #69650: Correspondence added
sorry dupe for 69651 forgot to enter a subject
  Thu Jul 21 07:46:59 2011 The RT System itself - Ticket #69650: Status changed from 'new' to 'open'
  Thu Jul 28 17:57:45 2011 https://peter.vereshagin.org/ - Correspondence added
On Thu Jul 21 07:38:38 2011, https://peter.vereshagin.org/ wrote: Show quoted text
> In certain condition ( unworkable DH parameters from php's openssl
That is about this: https://bugs.php.net/bug.php?id=55259 Show quoted text
> extension avoids from DH's g and p parameters to be read from key
  Thu Jul 28 18:04:26 2011 The RT System itself - Status changed from 'new' to 'open'
  Thu Jul 28 18:04:30 2011 https://peter.vereshagin.org/ - Correspondence added
On Thu Jul 21 07:38:38 2011, https://peter.vereshagin.org/ wrote: Show quoted text
> In certain condition ( unworkable DH parameters from php's openssl
That is about this: https://bugs.php.net/bug.php?id=55259 Show quoted text
> extension avoids from DH's g and p parameters to be read from key
  Mon Nov 14 21:20:36 2011 crew [...] cs.stanford.edu - Ticket #69650: Merged into ticket #69651
  Mon Nov 14 21:20:36 2011 crew [...] cs.stanford.edu - Merged into ticket #69651
  Mon Nov 14 21:22:09 2011 crew [...] cs.stanford.edu - Ticket deleted
  Mon Nov 14 21:22:19 2011 crew [...] cs.stanford.edu - Status changed from 'deleted' to 'open'