Bug #69622 for XML-LibXML:

Wed Jul 20 11:49:06 2011 VKON [...] cpan.org - Ticket created

starting from 1.75 version there is this chunk of code in "perl-libxml-sax.c" file, in several functions, which cause trouble: .... if (sax->joinchars) { PSaxCharactersFlush(ctxt, sax->charbuf); } dSP; .... The problem is that the file is C (as opposed to C++) and you're only allowed to declare something before any code, and declaration "dSP;" happens to be after the "if" statement. Moving the "if" after "dSP;" looks more consistent. Regards, Vadim.

Wed Jul 20 15:59:35 2011 SHLOMIF [...] cpan.org - Correspondence added

Hi Vadim, On Wed Jul 20 11:49:06 2011, VKON wrote: Show quoted text

> starting from 1.75 version there is this chunk of code in > "perl-libxml-sax.c" file, in several functions, which cause trouble: > > .... > if (sax->joinchars) > { > PSaxCharactersFlush(ctxt, sax->charbuf); > } > > dSP; > .... > > The problem is that the file is C (as opposed to C++) and you're only > allowed to declare something before any code, and declaration "dSP;" > happens to be after the "if" statement. > > Moving the "if" after "dSP;" looks more consistent. >

thanks for your report. This was fixed in the bitbucket repository and will be released soon. It took me more time than usual because ssh was broken in Mandriva Cooker when the nscd daemon was running due to a glibc upgrade. You have been credited. Regards, -- Shlomi Fish

Wed Jul 20 15:59:36 2011 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 20 15:59:36 2011 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jul 21 03:47:03 2011 VKON [...] cpan.org - Status changed from 'resolved' to 'open'

Thu Jul 21 03:51:20 2011 VKON [...] cpan.org - Correspondence added

I've downloaded freshly released XML-LibXML-1.82 and, while indeed some such places are fixed, it still has such a problem in 3 more places: perl-libxml-sax.c(1109) : error C2275: 'SV' : illegal use of this type as an expression .... perl-libxml-sax.c(1154) : error C2275: 'SV' : illegal use of this type as an expression .... perl-libxml-sax.c(1221) : error C2275: 'SV' : illegal use of this type as an expression I do see that the problem was resolved in other 3 or 4 functions in that file Thanks for quick reply and resolution, BTW.

Thu Jul 21 08:14:19 2011 SHLOMIF [...] cpan.org - Correspondence added

On Thu Jul 21 03:51:20 2011, VKON wrote: Show quoted text

> I've downloaded freshly released XML-LibXML-1.82 and, while indeed some > such places are fixed, it still has such a problem in 3 more places: > > perl-libxml-sax.c(1109) : error C2275: 'SV' : illegal use of this type > as an expression > .... > perl-libxml-sax.c(1154) : error C2275: 'SV' : illegal use of this type > as an expression > .... > perl-libxml-sax.c(1221) : error C2275: 'SV' : illegal use of this type > as an expression > > I do see that the problem was resolved in other 3 or 4 functions in that > file > > Thanks for quick reply and resolution, BTW.

Hi, this time I fixed it and verified this was the case everywhere by adding the flags "-Wdeclaration-after-statement -Werror" to "CCFLAGS" in the makefile. I will release it to CPAN soon. Regards, Shlomi Fish

Thu Jul 21 08:15:05 2011 SHLOMIF [...] cpan.org - Correspondence added

Resolved in the repository. Will be uploaded to CPAN soon.

Thu Jul 21 08:15:07 2011 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'