Skip Menu |

This queue is for tickets about the Net-Appliance-Frontpanel CPAN distribution.

Report information
The Basics
Id: 69576
Status: rejected
Priority: 0/
Queue: Net-Appliance-Frontpanel

People
Owner: Nobody in particular
Requestors: dean [...] fragfest.com.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: /usr/bin/frontpanel creates object without checking $configfile
the 'frontpanel' script tries to create the N::A::F object, even if no options are provided. so if the configfile isnt present, it dies. this should do something more like GetOptions( %foo, 'help|h' => \&help, ) or &help; if ($conditions) { ## some code here else { help() } sub help { print "Do Stuff" }
Subject: Re: [rt.cpan.org #69576] /usr/bin/frontpanel creates object without checking $configfile
Date: Tue, 19 Jul 2011 21:28:39 +0100
To: bug-Net-Appliance-Frontpanel [...] rt.cpan.org
From: Oliver Gorwits <oliver [...] cpan.org>
Hi Dean, On 19/07/2011 15:28, Dean Hamstead via RT wrote: Show quoted text
> the 'frontpanel' script tries to create the N::A::F object, even if no > options are provided. so if the configfile isnt present, it dies.
Gosh, the frontpanel code hasn't had much love in a long time, so thanks for taking time to give me the feedback. Show quoted text
> this should do something more like
I'll need to import Frontpanel to my github account and apply the patch, which might wait for me to have a little spare time. Sorry the code is a bit rotten. It does work - but isn't really how I'd have liked to add a feature to Netdisco, in an ideal world. We'd be better off with a plugin system... kindest regards, oliver.
Subject: Re: [rt.cpan.org #69576] /usr/bin/frontpanel creates object without checking $configfile
Date: Wed, 20 Jul 2011 10:44:23 +1000
To: bug-Net-Appliance-Frontpanel [...] rt.cpan.org
From: Dean Hamstead <dean [...] fragfest.com.au>
Ive not actually gotten the whole thing to work and have given up. But figured i would add a bug while im logged in to RT. It seemed that the config loader was considering our netdisco.conf to be perl format and i lost interest chasing it. Perhaps the best approach would be to create a new set of modules that creates switch images (and or maps) based on a config and a provided description hash. Something like SNMP::Info. Out of the box such a solution might provide generic images which can be drop in replaced with vendor provided images (maybe include the md5 of the intended vendor image for convenience) /dream On 20/07/11 06:28, Oliver Gorwits via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=69576> > > Hi Dean, > > On 19/07/2011 15:28, Dean Hamstead via RT wrote:
>> the 'frontpanel' script tries to create the N::A::F object, even if no >> options are provided. so if the configfile isnt present, it dies.
> > Gosh, the frontpanel code hasn't had much love in a long time, so thanks > for taking time to give me the feedback. >
>> this should do something more like
> > I'll need to import Frontpanel to my github account and apply the patch, > which might wait for me to have a little spare time. > > Sorry the code is a bit rotten. It does work - but isn't really how I'd > have liked to add a feature to Netdisco, in an ideal world. We'd be > better off with a plugin system... > > kindest regards, > oliver. > > >