On Thu, 7 Jul 2011 07:13:54 -0400, "Kevin Frost via RT"
<bug-DBD-CSV@rt.cpan.org> wrote:
Show quoted text> I stand corrected on the oversight assumption.
>
> If you don't agree it's a bug just mark it invalid with your explanation;
> I can see the logic that it's harmless when used by Perl.
>
> I didn't mean to imply that you have some responsibility to make rpmbuild
> happy, just that you might want to prevent others from stumbling over
> the same issue in the future.
As I already replied in another mail, I already committed that change
in the git repository based on the same patch that OpenSUSE did to this
module.
SO it is clear that I don't disapprove of the change. I disapprove of
the reasoning you came with to motivate me to make that change.
Show quoted text> If you prefer to require that people use patches that's a perfectly
> reasonable position, just not one I'd expected.
>
> I don't think there's any difference between setting the line to
> /usr/bin/perl, /pro/bin/perl, or /anything/you/like, since any of
> these may or may not be present on the build system.
There *is* a difference. For me. The rest of the world won't ever see
the difference.
I quite often make a module an executable, so I can then test inside
functionality from the command prompt without the need of a complete
working environment. Before I commit, I remove that testing code, so
you won't ever see that. Example, at the end of (a random) module:
--8<---
# Try a basic Command Line Interface. Way open for improvements
unless (caller) {
use Data::Peek;
my $user = getpwuid $<;
my $rv = InternalMethod (undef, @ARGV);
DDumper { in => \@ARGV, out => $rv };
exit 0;
}
1;
Show quoted text> I apologize for using the word "nonstandard" which implied I saw
> a difference.
No need for apologies.
Show quoted text> Anyway, it's not unused by everyone but you, because I just used
> it, even if not in the manner intended. :-)
Please post/mail me (preferably not through RT) any changes Redhat
applies to my modules and I will seriously look into them.
Show quoted text> I don't mind if you kill the bug, I would have filed it as
> "trivial" or "favor to RedHat RPM builders" if I could have.
I won't
Show quoted text> cheers
> -- kf.
--
H.Merijn Brand
http://tux.nl Perl Monger
http://amsterdam.pm.org/
using 5.00307 through 5.14 and porting perl5.15.x on HP-UX 10.20, 11.00,
11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.4 and AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
