Skip Menu |

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 69248
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: GRAF [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: 'make test' fails with a non-english locale setting
t/01basic.t ......................... ok # Failed test 'error parsing non-existant does_not_exist.xml' # at t/02parse.t line 228. # 'Could not create file parser context for file "does_not_exist.xml": Datei oder Verzeichnis nicht gefunden at t/02parse.t line 227 # ' # doesn't match '(?^:^Could not create file parser context for file "does_not_exist.xml": No such file or directory at)' # Looks like you failed 1 test of 531. Current workaround: LANG=C make test This should be done in the test. Or better test error codes (== ENOENT) instead of a string.
On Sat Jul 02 08:32:15 2011, GRAF wrote: Show quoted text
> t/01basic.t ......................... ok > > # Failed test 'error parsing non-existant does_not_exist.xml' > # at t/02parse.t line 228. > # 'Could not create file parser context for file > "does_not_exist.xml": Datei oder Verzeichnis nicht gefunden at > t/02parse.t line 227 > # ' > # doesn't match '(?^:^Could not create file parser context for file > "does_not_exist.xml": No such file or directory at)' > # Looks like you failed 1 test of 531. > > Current workaround: > LANG=C make test > > This should be done in the test. > Or better test error codes (== ENOENT) instead of a string.
I added a POSIX::setlocale() call in t/02parse.t to mitigate it. This will be available in the next release. Regards, -- Shlomi Fish
From: leosusanto [...] gmail.com
Hi, it's still borking P5.10.1 while testing SHLOMIF/XML-LibXML-1.90.tar.gz # Compiled against libxml2 version: 20708 # Running libxml2 version: 20708 # t/01basic.t ......................... ok # Failed test 'error parsing non-existent does_not_exist.xml' # at t/02parse.t line 238. # 'Could not create file parser context for file "does_not_exist.xml": No error at t/02parse.t line 237 # ' # doesn't match '(?-xism:\ACould not create file parser context for file "does_not_exist\.xml": No\ such\ file\ or\ directory)' # Looks like you failed 1 test of 531. t/02parse.t ......................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/531 subtests t/03doc.t ........................... ok On Sat Jul 02 10:25:47 2011, SHLOMIF wrote: Show quoted text
> On Sat Jul 02 08:32:15 2011, GRAF wrote:
> > t/01basic.t ......................... ok > > > > # Failed test 'error parsing non-existant does_not_exist.xml' > > # at t/02parse.t line 228. > > # 'Could not create file parser context for file > > "does_not_exist.xml": Datei oder Verzeichnis nicht gefunden at > > t/02parse.t line 227 > > # ' > > # doesn't match '(?^:^Could not create file parser context for file > > "does_not_exist.xml": No such file or directory at)' > > # Looks like you failed 1 test of 531. > > > > Current workaround: > > LANG=C make test > > > > This should be done in the test. > > Or better test error codes (== ENOENT) instead of a string.
> > I added a POSIX::setlocale() call in t/02parse.t to mitigate it. > > This will be available in the next release. > > Regards, > > -- Shlomi Fish
RT-Send-CC: leosusanto [...] gmail.com
Hello, On Mon Jan 23 18:23:55 2012, nyet wrote: Show quoted text
> Hi, it's still borking P5.10.1 while testing
SHLOMIF/XML-LibXML-1.90.tar.gz Show quoted text
> > # Compiled against libxml2 version: 20708 > # Running libxml2 version: 20708 > # > t/01basic.t ......................... ok > > # Failed test 'error parsing non-existent does_not_exist.xml' > # at t/02parse.t line 238. > # 'Could not create file parser context for file > "does_not_exist.xml": No error at t/02parse.t line 237 > # ' > # doesn't match '(?-xism:\ACould not create file parser context for > file "does_not_exist\.xml": No\ such\ file\ or\ directory)' > # Looks like you failed 1 test of 531.
This is not related to the locale. This time what happens is that the wrong error is returned. I don't know why, but it's a different issue. Can you provide more details on your system and maybe investigate what is happening using a debugger? Regards, -- Shlomi Fish Show quoted text
> t/02parse.t ......................... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/531 subtests > t/03doc.t ........................... ok > > > > > On Sat Jul 02 10:25:47 2011, SHLOMIF wrote:
> > On Sat Jul 02 08:32:15 2011, GRAF wrote:
> > > t/01basic.t ......................... ok > > > > > > # Failed test 'error parsing non-existant does_not_exist.xml' > > > # at t/02parse.t line 228. > > > # 'Could not create file parser context for file > > > "does_not_exist.xml": Datei oder Verzeichnis nicht gefunden at > > > t/02parse.t line 227 > > > # ' > > > # doesn't match '(?^:^Could not create file parser context for
file Show quoted text
> > > "does_not_exist.xml": No such file or directory at)' > > > # Looks like you failed 1 test of 531. > > > > > > Current workaround: > > > LANG=C make test > > > > > > This should be done in the test. > > > Or better test error codes (== ENOENT) instead of a string.
> > > > I added a POSIX::setlocale() call in t/02parse.t to mitigate it. > > > > This will be available in the next release. > > > > Regards, > > > > -- Shlomi Fish
> >
Subject: Re: [rt.cpan.org #69248] 'make test' fails with a non-english locale setting
Date: Wed, 25 Jan 2012 10:21:40 -0800
To: bug-XML-LibXML [...] rt.cpan.org
From: Leo Susanto <leosusanto [...] gmail.com>
Shlomi, I updated t/02parse.t by adding diag functions: { # This is to fix https://rt.cpan.org/Public/Bug/Display.html?id=69248 # Testing for localised error messages. $! = ENOENT; my $err_string = "$!"; $! = 0; my $re = qr/\ACould not create file parser context for file "\Q$badfile2\E": \Q$err_string\E/; eval { $parser->parse_file($badfile2); }; like($@, $re, "error parsing non-existent $badfile2"); diag("\$\@: |$@|"); diag("\$err_string: |$err_string|"); } This is what I get: C:\CPANTesters\Perl5.10.1\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib\lib', 'blib\arch')" t/02parse.t t/02parse.t .. 1/531 # Failed test 'error parsing non-existent does_not_exist.xml' # at t/02parse.t line 238. # 'Could not create file parser context for file "does_not_exist.xml": No error at t/02parse.t line 237 # ' # doesn't match '(?-xism:\ACould not create file parser context for file "does_not_exist\.xml": No\ such\ file\ or\ directory)' # $@: |Could not create file parser context for file "does_not_exist.xml": No error at t/02parse.t line 237 # | # $err_string: |No such file or directory| t/02parse.t .. 312/531 # Looks like you failed 1 test of 531. t/02parse.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/531 subtests Looks like no error is thrown. I'll look into it further... On Tue, Jan 24, 2012 at 12:53 AM, Shlomi Fish via RT <bug-XML-LibXML@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=69248 > > > Hello, > > On Mon Jan 23 18:23:55 2012, nyet wrote:
>> Hi, it's still borking P5.10.1 while testing
> SHLOMIF/XML-LibXML-1.90.tar.gz
>> >> # Compiled against libxml2 version: 20708 >> # Running libxml2 version:          20708 >> # >> t/01basic.t ......................... ok >> >> #   Failed test 'error parsing non-existent does_not_exist.xml' >> #   at t/02parse.t line 238. >> #                   'Could not create file parser context for file >> "does_not_exist.xml": No error at t/02parse.t line 237 >> # ' >> #     doesn't match '(?-xism:\ACould not create file parser context for >> file "does_not_exist\.xml": No\ such\ file\ or\ directory)' >> # Looks like you failed 1 test of 531.
> > This is not related to the locale. This time what happens is that the > wrong error is returned. I don't know why, but it's a different issue. > > Can you provide more details on your system and maybe investigate what > is happening using a debugger? > > Regards, > > -- Shlomi Fish >
>> t/02parse.t ......................... >> Dubious, test returned 1 (wstat 256, 0x100) >> Failed 1/531 subtests >> t/03doc.t ........................... ok >> >> >> >> >> On Sat Jul 02 10:25:47 2011, SHLOMIF wrote:
>> > On Sat Jul 02 08:32:15 2011, GRAF wrote:
>> > > t/01basic.t ......................... ok >> > > >> > > #   Failed test 'error parsing non-existant does_not_exist.xml' >> > > #   at t/02parse.t line 228. >> > > #                   'Could not create file parser context for file >> > > "does_not_exist.xml": Datei oder Verzeichnis nicht gefunden at >> > > t/02parse.t line 227 >> > > # ' >> > > #     doesn't match '(?^:^Could not create file parser context for
> file
>> > > "does_not_exist.xml": No such file or directory at)' >> > > # Looks like you failed 1 test of 531. >> > > >> > > Current workaround: >> > > LANG=C make test >> > > >> > > This should be done in the test. >> > > Or better test error codes (== ENOENT) instead of a string.
>> > >> > I added a POSIX::setlocale() call in t/02parse.t to mitigate it. >> > >> > This will be available in the next release. >> > >> > Regards, >> > >> > -- Shlomi Fish
>> >>
> > >
Subject: Re: [rt.cpan.org #69248] 'make test' fails with a non-english locale setting
Date: Fri, 27 Jan 2012 12:49:10 -0800
To: bug-XML-LibXML [...] rt.cpan.org
From: Leo Susanto <leosusanto [...] gmail.com>
I think I know why it's not throwing the correct error: cl -c -nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_ST RICT -DHAVE_DES_FCRYPT -DUSE_SITECUSTOMIZE -DPRIVLIB_LAST_IN_INC -DPERL_IMPLICIT _CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX -MD -Zi -DNDEBUG -O1 -DVERSION=\"1.90\" -DXS_VERSION=\"1.90\" "-IC:\CPANTesters\Perl5.10.1\ lib\CORE" -DHAVE_UTF8 -DHAVE_BLANK Av_CharPtrPtr.c Av_CharPtrPtr.c C:\CPANTesters\Perl5.10.1\lib\CORE\sys/socket.h(34) : warning C4005: 'ENOTSOCK' : macro redefinition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\errno.h(120) : see previous definition of 'ENOTSOCK' Av_CharPtrPtr.c(58) : warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE _NO_WARNINGS. See online help for details. C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\string.h(105) : see declaration of 'strcpy' C:\CPANTesters\Perl5.10.1\bin\perl.exe C:\CPANTesters\Perl5.10.1\site\li b\ExtUtils\xsubpp -typemap C:\CPANTesters\Perl5.10.1\lib\ExtUtils\typemap -type map typemap Devel.xs > Devel.xsc && C:\CPANTesters\Perl5.10.1\bin\perl.exe -MEx tUtils::Command -e mv -- Devel.xsc Devel.c I'll see what I can do about this. On Wed, Jan 25, 2012 at 10:21 AM, Leo Susanto <leosusanto@gmail.com> wrote: Show quoted text
> Shlomi, > > I updated t/02parse.t by adding diag functions: > { >    # This is to fix https://rt.cpan.org/Public/Bug/Display.html?id=69248 >    # Testing for localised error messages. >    $! = ENOENT; >    my $err_string = "$!"; >    $! = 0; > >    my $re = qr/\ACould not create file parser context for file > "\Q$badfile2\E": \Q$err_string\E/; > >    eval { $parser->parse_file($badfile2); }; >    like($@, $re, "error parsing non-existent $badfile2"); >        diag("\$\@: |$@|"); >        diag("\$err_string: |$err_string|"); > } > > This is what I get: > > C:\CPANTesters\Perl5.10.1\bin\perl.exe "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'inc', 'blib\lib', 'blib\arch')" t/02parse.t > t/02parse.t .. 1/531 > #   Failed test 'error parsing non-existent does_not_exist.xml' > #   at t/02parse.t line 238. > #                   'Could not create file parser context for file > "does_not_exist.xml": No error at t/02parse.t line 237 > # ' > #     doesn't match '(?-xism:\ACould not create file parser context > for file "does_not_exist\.xml": No\ such\ file\ or\ directory)' > # $@: |Could not create file parser context for file > "does_not_exist.xml": No error at t/02parse.t line 237 > # | > # $err_string: |No such file or directory| > t/02parse.t .. 312/531 # Looks like you failed 1 test of 531. > t/02parse.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/531 subtests > > Looks like no error is thrown. I'll look into it further... > > > On Tue, Jan 24, 2012 at 12:53 AM, Shlomi Fish via RT > <bug-XML-LibXML@rt.cpan.org> wrote:
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=69248 > >> >> Hello, >> >> On Mon Jan 23 18:23:55 2012, nyet wrote:
>>> Hi, it's still borking P5.10.1 while testing
>> SHLOMIF/XML-LibXML-1.90.tar.gz
>>> >>> # Compiled against libxml2 version: 20708 >>> # Running libxml2 version:          20708 >>> # >>> t/01basic.t ......................... ok >>> >>> #   Failed test 'error parsing non-existent does_not_exist.xml' >>> #   at t/02parse.t line 238. >>> #                   'Could not create file parser context for file >>> "does_not_exist.xml": No error at t/02parse.t line 237 >>> # ' >>> #     doesn't match '(?-xism:\ACould not create file parser context for >>> file "does_not_exist\.xml": No\ such\ file\ or\ directory)' >>> # Looks like you failed 1 test of 531.
>> >> This is not related to the locale. This time what happens is that the >> wrong error is returned. I don't know why, but it's a different issue. >> >> Can you provide more details on your system and maybe investigate what >> is happening using a debugger? >> >> Regards, >> >> -- Shlomi Fish >>
>>> t/02parse.t ......................... >>> Dubious, test returned 1 (wstat 256, 0x100) >>> Failed 1/531 subtests >>> t/03doc.t ........................... ok >>> >>> >>> >>> >>> On Sat Jul 02 10:25:47 2011, SHLOMIF wrote:
>>> > On Sat Jul 02 08:32:15 2011, GRAF wrote:
>>> > > t/01basic.t ......................... ok >>> > > >>> > > #   Failed test 'error parsing non-existant does_not_exist.xml' >>> > > #   at t/02parse.t line 228. >>> > > #                   'Could not create file parser context for file >>> > > "does_not_exist.xml": Datei oder Verzeichnis nicht gefunden at >>> > > t/02parse.t line 227 >>> > > # ' >>> > > #     doesn't match '(?^:^Could not create file parser context for
>> file
>>> > > "does_not_exist.xml": No such file or directory at)' >>> > > # Looks like you failed 1 test of 531. >>> > > >>> > > Current workaround: >>> > > LANG=C make test >>> > > >>> > > This should be done in the test. >>> > > Or better test error codes (== ENOENT) instead of a string.
>>> > >>> > I added a POSIX::setlocale() call in t/02parse.t to mitigate it. >>> > >>> > This will be available in the next release. >>> > >>> > Regards, >>> > >>> > -- Shlomi Fish
>>> >>>
>> >> >>
Subject: Re: [rt.cpan.org #69248] 'make test' fails with a non-english locale setting
Date: Fri, 28 Sep 2012 12:30:55 -0700
To: bug-XML-LibXML [...] rt.cpan.org
From: Leo Susanto <leosusanto [...] gmail.com>
Shlomi, I dug into this but I can not understand it. It seems that it's not a problem with XML::LibXML, but something else. I'll ask Jan Dubois about it since this involves perl on win32. Leo Susanto
On Fri Sep 28 15:31:05 2012, nyet wrote: Show quoted text
> Shlomi, > > I dug into this but I can not understand it. It seems that it's not a > problem with XML::LibXML, but something else. I'll ask Jan Dubois > about it since this involves perl on win32. > > Leo Susanto
Resolving this ticket then.