Skip Menu |

This queue is for tickets about the DBD-XBase CPAN distribution.

Report information
The Basics
Id: 69208
Status: rejected
Priority: 0/
Queue: DBD-XBase
People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: (no value)
Fixed in:
  • 1.00
  • 1.01
  • 1.02
  • 1.03

History Show all quoted text
  Thu Jun 30 15:26:20 2011 ribasushi [...] leporine.io - Ticket created
Subject: Please change minimum perl version back to 5.8
There is nothing in this codebase that warrants perl 5.10. In fact all it needs is the attached patch, with 0 code changes. Tested on multiple 5.8 perls all the way back to 5.8.1 itself. Cheers diff --git a/Makefile.PL b/Makefile.PL index 69cc5ec..e9a0abc 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,5 +1,5 @@ -use 5.010; +use 5.008001; { local $SIG{__WARN__} = sub {}; diff --git a/lib/XBase.pm b/lib/XBase.pm index b345c7e..447c86d 100644 --- a/lib/XBase.pm +++ b/lib/XBase.pm @@ -10,7 +10,7 @@ XBase - Perl module for reading and writing the dbf files # ############ package XBase; -use 5.010; +use 5.008001; use strict; use XBase::Base; # will give us general methods diff --git a/lib/XBase/FAQ.pod b/lib/XBase/FAQ.pod index dc5cb10..5d35eb9 100644 --- a/lib/XBase/FAQ.pod +++ b/lib/XBase/FAQ.pod @@ -19,7 +19,7 @@ Jan Pazdziora =item What Perl version do I need? What other modules? -You need perl 5.10 or newer. You need B<DBI> module version 1.00 +You need perl 5.8.1 or newer. You need B<DBI> module version 1.00 or higher, if you want to use the DBD driver (which you should). =item Can I use B<XBase.pm> under Windows 95/NT?
  Fri Jul 08 11:07:53 2011 JANPAZ [...] cpan.org - Correspondence added
On Thu Jun 30 15:26:20 2011, RIBASUSHI wrote: Show quoted text
> There is nothing in this codebase that warrants perl 5.10. In fact all > it needs is the attached patch, with 0 code changes. Tested on multiple > 5.8 perls all the way back to 5.8.1 itself.
Did you also verify this on Windows? We used to have problems with that O_BINARY constant in Fcntl, that's why I've decided to bump it up to 5.10. -- Jan Pazdziora
  Fri Jul 08 11:07:54 2011 The RT System itself - Status changed from 'new' to 'open'
  Wed Aug 22 16:01:56 2012 SREZIC [...] cpan.org - Correspondence added
On 2011-07-08 11:07:53, JANPAZ wrote: Show quoted text
> On Thu Jun 30 15:26:20 2011, RIBASUSHI wrote:
> > There is nothing in this codebase that warrants perl 5.10. In fact all > > it needs is the attached patch, with 0 code changes. Tested on multiple > > 5.8 perls all the way back to 5.8.1 itself.
> > Did you also verify this on Windows? We used to have problems with that > O_BINARY constant in Fcntl, that's why I've decided to bump it up to 5.10.
Then you can still write something like: use 5.008; if ($^O eq 'MSWin32') { die "..." if $] < 5.010; } Or even better, test for the feature, not for the version. I am not sure what the problem was: the existence of O_BINARY? its value? But either should be testable. Regards, Slaven
  Sat Aug 25 07:45:26 2012 JANPAZ [...] cpan.org - Correspondence added
On Wed Aug 22 16:01:56 2012, SREZIC wrote: Show quoted text
> > Or even better, test for the feature, not for the version. I am not sure > what the problem was: the existence of O_BINARY? its value? But either > should be testable.
This is what we had there in the pre-1.0 versions there. But it made the code messy. Anybody still running 5.8 is welcome to use 0.241 from backpan.
  Sat Aug 25 07:45:28 2012 JANPAZ [...] cpan.org - Status changed from 'open' to 'rejected'