| Subject: | small bug in parsing rare (legal) SAN moves |
| Date: | Thu, 30 Jun 2011 10:42:37 -0700 |
| To: | bug-Chess-PGN-EPD [...] rt.cpan.org |
| From: | "ludens [...] gmail.com" <ludens [...] gmail.com> |
Hi,
Chess-PGN-EPD-0.29 has a little problem parsing rare legal SAN moves.
White's move 68 in the example game (Rf8f2, see below) fails with
undefined $from in epdlist because movetype returns "Not yet handled".
It looks like this (non-capture) case was just forgotten because it is
already there for capturing moves.
Proposed fix: Add
elsif ( $move =~ /^([RNBQK])([a-h][1-8])([a-h][1-8])(?:\+|\#)?$/ ) {
@result = ( $1, $3, $2 );
}
in line 1049 (function movetype).
Also, line 706 should read
my $debug = @_ ? ( $moves[-1] eq '1' ) : 0;
to make sure debug is 0 instead of undefined for empty move lists (ie
White or Black resigns on move 1).
Thank you for an extremly valuable library, it is nice to see that you
keep improving it.
Klaus
-----------
example game
1. d4 g6 2. Bf4 Bg7 3. Nf3 d6 4. Nc3 Nf6 5. e3 O-O 6. Qd3 Nbd7 7. h4 c5
8. dxc5 Nxc5 9. Qe2 b6 10. O-O-O Ba6 11. Qe1 Bxf1 12. Qxf1 Nce4 13. Nxe4
Nxe4 14. g4 Rc8 15. Qd3 Nc5 16. Qe2 b5 17. h5 Qa5 18. a3 Qa4 19. c3 Nb3+
20. Kb1 b4 21. cxb4 a5 22. bxa5 Nxa5 23. hxg6 fxg6 24. Bh6 Bxb2 25. Bxf8
Qxa3 26. Qxb2 Qa4 27. Qa2+ Qc4 28. Qxc4+ Rxc4 29. Bxe7 Nc6 30. Bxd6 Ra4
31. Rd2 Rxg4 32. Ne5 Ra4 33. Nxc6 Ra6 34. Rc2 Rb6+ 35. Kc1 Kf7 36. Rxh7+
Ke6 37. Bf4 Kd5 38. Ne7+ Ke4 39. Rg7 Kf3 40. Rxg6 Ra6 41. Rxa6 Kg2 42.
Kd1 Kf1 43. Rca2 Kg2 44. Bh6 Kf3 45. Re6 Kg4 46. Nc6 Kf5 47. Rd6 Kg4 48.
Rdd2 Kf3 49. Bf8 Kg2 50. Re2 Kf3 51. e4 Kf4 52. e5 Kf3 53. e6 Kg2 54.
Ba3 Kf1 55. e7 Kg2 56. Re1 Kf3 57. e8=R Kf4 58. Rf8+ Kg5 59. f3 Kg6 60.
f4 Kg7 61. f5 Kh7 62. Ra8 Kg7 63. Rf1 Kf6 64. Nd4 Kf7 65. f6 Kg6 66. f7
Kg5 67. f8=R Kg4 68. Rf8f2 Kg3 69. Rae2 Kg4 70. Rae8 Kg3 71. R8e3+ Kg4
72. Ree1 Kg5 73. Bb2 Kg4 74. Bc3 Kg5 75. Re1e2 Kg4 76. Be1 Kg5 77. Nc2
Kg4 78. Kd2 Kg5 79. Kd3 Kg4 80. Kd4 Kg5 81. Kc4 Kg4 82. Kd5 Kg5 83. Bd2
Kg4 84. Ne1 Kg5 85. Rd3+ Kg4 86. Bc1 Kh5 87. Rd1 Kg6 88. Bd2 Kg7 89. Re3
Kg6 90. Rfe2 Kg7 91. Rff3 Kg6 92. Rff2 Kg7 93. Rf1 Kg6 94. Rff2 Kg7 95.
Rf4 Kg6 96. Rd4 Kg7 97. Rdd3 Kg6 98. Rc3 Kg7 99. Rc2 Kg6 100. Rcc1 Kg7
101. Rcc3 Kg6 102. Rc2 Kg7 103. Rcc1 Kg6 104. Rc4 Kg7 105. Rb4 Kg6 106. Rbb3