| CC: | |
| Subject: | Fwd: [bestpractical.com #45121] Re: [jifty] Don't require that Popout region links be in a region already or specify an element (a632c54) |
| Date: | Thu, 30 Jun 2011 11:28:43 -0400 |
| To: | bug-Jifty [...] rt.cpan.org |
| From: | github [...] bestpractical.com |
This is forward of transaction #842266 of a ticket #45121
Message body is not shown because sender requested not to inline it.
| Subject: | Re: [jifty] Don't require that Popout region links be in a region already or specify an element (a632c54) |
| Date: | Wed, 8 Jun 2011 14:14:55 -0700 |
| To: | github [...] bestpractical.com |
| From: | tsibley <reply+c-421369-f233327f23732bb6f8af8c5bdf9da5dea913c745 [...] reply.github.com> |
I just discovered that this introduces a bug when using Popout and the toggle => 1 option. On the first click, the popout will display. On the second click, the content of your entire page disappears since jifty.js does some shortcutting and calls jQuery(element).empty(). Since we hardcode the target element as "body" in Element.pm, the <body> node is emptied. Whoops!
--
Reply to this email directly or view it on GitHub:
https://github.com/bestpractical/jifty/commit/a632c54df8d893fca1dbafbbf528f48a6ed13e50#commitcomment-421369