Bug #69174 for Net-DNS: Net::DNS::Nameserver

Wed Jun 29 01:46:34 2011 bbb [...] cpan.org - Ticket created

CC:	bbb [...] cpan.org
Subject:	Net::DNS::Nameserver - TCP outbuffer

Calling Net::DNS::Nameserver->tcp_connection with undef instead of a real socket causes undesired results. It's pretty obvious that robert just made a typo. Attached is a patch to correct the problem.

Subject:

Net-DNS-0.66-outbuffer_tcp_connection.patch

diff -wuir Net-DNS-0.66.ORIG/lib/Net/DNS/Nameserver.pm Net-DNS-0.66/lib/Net/DNS/Nameserver.pm --- Net-DNS-0.66.ORIG/lib/Net/DNS/Nameserver.pm 2009-12-30 04:01:39.000000000 -0700 +++ Net-DNS-0.66/lib/Net/DNS/Nameserver.pm 2011-06-28 23:32:41.000000000 -0600 @@ -472,7 +472,7 @@ # send the response... well, unless it's a lot of tiny queries, # in which case we will be generating an entire TCP packet per # reply. --robert - $self->tcp_connection($self->{"_tcp"}{"socket"}); + $self->tcp_connection($self->{"_tcp"}{$s}{"socket"}); } } $self->{"_tcp"}{$s}{"timeout"} = time()+120;

Wed Jun 29 01:55:23 2011 bbb [...] cpan.org - Broken in 0.66 added

Wed Jun 29 01:55:23 2011 bbb [...] cpan.org - Broken in 0.61 deleted

Wed Jun 29 01:55:24 2011 bbb [...] cpan.org - Broken in 0.62 deleted

Wed Jun 29 01:55:24 2011 bbb [...] cpan.org - Broken in 0.63 deleted

Wed Jun 29 01:55:24 2011 bbb [...] cpan.org - Broken in 0.64 deleted

Wed Jun 29 01:55:24 2011 bbb [...] cpan.org - Broken in 0.65 deleted

Wed Jun 29 01:55:34 2011 bbb [...] cpan.org - Severity Normal added

Fri Jul 22 10:55:40 2011 willem [...] cpan.org - Correspondence added

Indeed typo fixed in trunk.

Fri Jul 22 10:55:41 2011 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 22 10:55:41 2011 willem [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jul 29 00:54:42 2011 bbb [...] cpan.org - Correspondence added

CC:	Rob Brown <bbb [...] cpan.org>
Subject:	Re: [rt.cpan.org #69174] Net::DNS::Nameserver - TCP outbuffer
Date:	Thu, 28 Jul 2011 22:54:33 -0600
To:	bug-Net-DNS [...] rt.cpan.org
From:	Rob Brown <bbb [...] cpan.org>

Okay, that's great that the trunk is fixed. Am I supposed to pull a snapshot from the trunk and bump the version to 0.67 and PAUSE it to CPAN? Or what am I supposed to do to verify if the patches are working? -- Rob On Fri, Jul 22, 2011 at 8:55 AM, Willem Toorop via RT <bug-Net-DNS@rt.cpan.org> wrote: Show quoted text

> Queue: Net-DNS > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=69174 > > > Indeed typo fixed in trunk. >

Fri Jul 29 00:54:43 2011 The RT System itself - Status changed from 'resolved' to 'open'

Tue Aug 02 07:03:15 2011 willem [...] nlnetlabs.nl - Correspondence added

Subject:	Re: [rt.cpan.org #69174] Net::DNS::Nameserver - TCP outbuffer
Date:	Tue, 02 Aug 2011 12:58:26 +0200
To:	bug-Net-DNS [...] rt.cpan.org
From:	Willem Toorop <willem [...] NLnetLabs.nl>

Hi Rob, unfortunately I was not able to do a release before my vacation, but I will do so as soon as I am back (in september) -- Verzonden van mijn Android telefoon met K-9 Mail. Rob Brown via RT <bug-Net-DNS@rt.cpan.org> wrote: Queue: Net-DNS Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=69174 > Okay, that's great that the trunk is fixed. Am I supposed to pull a snapshot from the trunk and bump the version to 0.67 and PAUSE it to CPAN? Or what am I supposed to do to verify if the patches are working? -- Rob On Fri, Jul 22, 2011 at 8:55 AM, Willem Toorop via RT <bug-Net-DNS@rt.cpan.org> wrote: Show quoted text

> Queue: Net-DNS > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=69174 > > > Indeed typo fixed in trunk. >

Wed Oct 19 06:08:08 2011 willem [...] cpan.org - Correspondence added

Well, as you know we are about to release. Closing the ticket, because as mentioned before, it is fixed. I will keep you informed on the release progress.

Wed Oct 19 06:08:09 2011 willem [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #69174 for Net-DNS: Net::DNS::Nameserver - TCP outbuffer