Bug #69134 for Device-Gsm: Patch for Device-Gsm-1.58

Tue Jun 28 13:52:46 2011 wilson [...] xyber.ph - Ticket created

Subject:	Patch for Device-Gsm-1.58
Date:	Tue, 28 Jun 2011 17:40:10 +0800
To:	bug-Device-Gsm [...] rt.cpan.org
From:	Wilson Santos <wilson [...] xyber.ph>

Hi Cosimo, I'd like to thank you for your work on the module. I've been experimenting with the UD.pm module, and would like to offer some fixes in the following areas, if you please. 1. extraction and return of the User Data Header (UDH) from the User Data token. This allows future development to support concatenated text, and extraction of other data types such as ringtones. This is returned as a hex-encoded string in Device::Gsm::Sms->{tokens}->{UD }->{_udh} 2. extraction and return of 8-bit data if indicated in the Data Coding Scheme (DCS). This is returned as a hex-encoded string in Device::Gsm::Sms->{tokens}->{UD }->{_bin} 3. option to handle UCS-2 encoded text as a hex encoded string, to preserve text in platforms that do not properly support UCS-2. This is also returned as a hex-encoded string in Device::Gsm::Sms->{tokens }->{UD}->{_bin} I've tried to preserve the existing return values to remain backward compatible. The self-tests still return ok. Please feel free to modify as you wish or to email me. thank you -- Wilson Santos

Message body is not shown because sender requested not to inline it.

Tue Jun 28 14:19:42 2011 cosimo [...] cpan.org - Correspondence added

On Tue Jun 28 13:52:46 2011, wilson@xyber.ph wrote: Show quoted text

> I'd like to thank you for your work on the module. > > I've been experimenting with the UD.pm module, and would like to

offer some Show quoted text

> fixes in the following areas, if you please.

Hi Wilson, thanks for your interest in this. Can you have a look here? https://github.com/gwozniak/perl5-device-gsm This is a fork of the official code: https://github.com/cosimo/perl5-device-gsm I believe this fork improves Device::Gsm in very similar areas as you did. Please take a look at Gregor's changes. Do you think you could use Gregor's work? Thanks, -- Cosimo

Tue Jun 28 14:19:42 2011 The RT System itself - Status changed from 'new' to 'open'

Wed Jun 29 00:14:50 2011 wilson [...] xyber.ph - Correspondence added

Subject:	Re: [rt.cpan.org #69134] Patch for Device-Gsm-1.58
Date:	Wed, 29 Jun 2011 12:14:11 +0800
To:	bug-Device-Gsm [...] rt.cpan.org
From:	Wilson Santos <wilson [...] xyber.ph>

Hi Cosimo, Thanks for this. This is indeed useful. I see that Gregor's work was mainly to support Concatenated SMS assembly (outside the module?), thus the changes in Structure. 8-bit data extraction through the DCS is not yet explicit, although there may be a way to handle this in PDU mode. On the other hand, being Lazy myself, I wanted to *avoid* a fork :) so the patch tries to minimize the changes and to stay away from compatibility problems. It just removes the extra characters that get prepended to $text if the UDH is present, and returns the UDH as an extra bonus. This "UDH within UD" design may not fit the architecture that you intended though, so again, please proceed as you see fit. Thanks and best regards On Wed, Jun 29, 2011 at 2:19 AM, Cosimo Streppone via RT < bug-Device-Gsm@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=69134 > > > On Tue Jun 28 13:52:46 2011, wilson@xyber.ph wrote: >

> > I'd like to thank you for your work on the module. > > > > I've been experimenting with the UD.pm module, and would like to

> offer some

> > fixes in the following areas, if you please.

> > > Hi Wilson, > > thanks for your interest in this. Can you have a look here? > > https://github.com/gwozniak/perl5-device-gsm > > This is a fork of the official code: > > https://github.com/cosimo/perl5-device-gsm > > I believe this fork improves Device::Gsm in very similar areas as you > did. Please take a look at Gregor's changes. Do you think you could use > Gregor's work? > > Thanks, > > -- > Cosimo > >

-- Wilson Santos

Wed Aug 03 17:39:35 2011 cosimo [...] cpan.org - Correspondence added 60 min

Hi Wilson, thanks again for your patch. After some consideration, I decided to merge Gregor's changes (github.com/ gwozniak/perl5-device-gsm). I think they are more flexible in case of future changes. As you said, UDH processing in UD was a bit confusing. I hope you will have some time to test Gregor's changes. They will be out in 1.59. If you find something's not working for you, I would really appreciate if you could rework your patch on top of Gregor's work. Cheers,

Wed Aug 03 17:39:36 2011 cosimo [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Aug 03 17:39:36 2011 cosimo [...] cpan.org - Given to COSIMO