Bug #68967 for Find-Lib: Getting the current directory from $ENV{PWD} is incorrect

Mon Jun 20 23:39:09 2011 DOY [...] cpan.org - Ticket created

Subject:

Getting the current directory from $ENV{PWD} is incorrect

$ENV{PWD} is only set by shells - if you do "chdir $somewhere_else" in perl, it will not be picked up. (Also, I think it's not very portable.) It should be using the Cwd module instead.

Wed Jun 29 14:11:42 2011 yann.kerherve [...] gmail.com - Correspondence added

On Mon Jun 20 23:39:09 2011, DOY wrote: Show quoted text

> $ENV{PWD} is only set by shells - if you do "chdir $somewhere_else" in > perl, it will not be picked up. (Also, I think it's not very portable.) > It should be using the Cwd module instead.

1.03_01 on cpan defaults to Cwd::cwd if $ENV{PWD} is not set. Cwd always resolves symlinks which will break Find::Lib on unix

Wed Jun 29 14:11:43 2011 The RT System itself - Status changed from 'new' to 'open'

Wed Jun 29 16:03:20 2011 DOY [...] cpan.org - Correspondence added

No, this is still broken. The reason I ran into this bug was when I ran a script which did a chdir, and Find::Lib returned the pre-chdir directory because it got it from $ENV{PWD} which isn't updated by perl's chdir(). $ENV{PWD} *cannot* be relied upon in any cases for this to be correct.

Fri Jul 01 00:47:31 2011 yann.kerherve [...] gmail.com - Correspondence added

On Wed Jun 29 16:03:20 2011, DOY wrote: Show quoted text

> No, this is still broken. The reason I ran into this bug was when I ran > a script which did a chdir, and Find::Lib returned the pre-chdir > directory because it got it from $ENV{PWD} which isn't updated by perl's > chdir(). $ENV{PWD} *cannot* be relied upon in any cases for this to be > correct.

Can you provide a test case or a little background on what program does that? It must be something very specific to do a chdir before even loading fully @INC. (Cwd::chdir updates $ENV{PWD}) Thanks

Fri Jul 01 08:59:07 2011 DOY [...] cpan.org - Correspondence added

The actual place I ran into this bug was when trying to install a module that used Find::Lib in its test suite. cpanm first does chdir into the dist build directory, and then runs (among other things) system("make test"). This runs the tests in a new subprocess, which is why no modules have been loaded yet. $ENV{PWD} is still pointing back to the directory I ran cpanm from (because chdir() doesn't update that), but the current working directory of the test process actually is the dist's build root, and that's what needs to be used.

Fri Jul 01 10:48:44 2011 yann.kerherve [...] gmail.com - Correspondence added

On Fri Jul 01 08:59:07 2011, DOY wrote: Show quoted text

> The actual place I ran into this bug was when trying to install a module > that used Find::Lib in its test suite. cpanm first does chdir into the > dist build directory, and then runs (among other things) system("make > test"). This runs the tests in a new subprocess, which is why no modules > have been loaded yet. $ENV{PWD} is still pointing back to the directory > I ran cpanm from (because chdir() doesn't update that), but the current > working directory of the test process actually is the dist's build root, > and that's what needs to be used.

Yeah, I suggested that cpanm uses Cwd::chdir which seems to be best practice: https://github.com/miyagawa/cpanminus/commit/36d76b5a35a883df53e4339bad350d670e9 dade0