Bug #68916 for PAR-Packer: Solaris with Sun Workshop: heavy cosmetic issue

Sat Jun 18 13:49:02 2011 nohuhu [...] nohuhu.org - Ticket created

Subject:	Solaris with Sun Workshop: heavy cosmetic issue
Date:	Sat, 18 Jun 2011 21:48:49 +0400
To:	<bug-PAR-Packer [...] rt.cpan.org>
From:	Alexander Tokarev <nohuhu [...] nohuhu.org>

Hi PAR::Packer maintainers, I was trying to build PAR::Packer 1.009 with Sun Workshop C Compiler I believe it's version 12 and encountered a bug that is, while being purely cosmetic, is nevertheless seriously annoying. The culprit is C code generated by myldr/file2c.pl on line 76: print $out "const char ${c_var}${suffix}[] = "; The resulting C code produces warnings like this: "my_libperl.c", line 8: warning: initializer does not fit or is out of range: 155 The problem is that C compiler warns literally on every line of the compiled my_libperl.c and my_par.c. Considering that I'm working remotely on a slow system, and my_libperl.c and my_par.c combined total to 38 mb of code, you can see why I didn't have the patience to wait till it builds The fix is really easy: either change "const char" to "const unsigned char" or add "-w" parameter to cc command line. I did that and PAR::Packer finished building in like five minutes instead of previously unfinished three hours. Hope you will approve this patch, it may save lots of frustration to fellow Solaris users. Regards, Alex.

Mon Jun 20 02:58:32 2011 RSCHUPP [...] cpan.org - Status changed from 'new' to 'open'

Mon Jun 20 02:58:34 2011 RSCHUPP [...] cpan.org - Taken

Sat Jun 25 11:40:05 2011 RSCHUPP [...] cpan.org - Correspondence added

On 2011-06-18 13:49:02, nohuhu@nohuhu.org wrote: Show quoted text

> print $out "const char ${c_var}${suffix}[] = ";

Thanks for reporting, your concerns will be addressed in the next release of PAR::Packer (all generated byte arrays will use "unsigned char"). Cheers, Roderich

Sat Jun 25 11:40:08 2011 RSCHUPP [...] cpan.org - Status changed from 'open' to 'patched'

Tue Jun 28 13:53:39 2011 nohuhu [...] nohuhu.org - Correspondence added

Subject:	Re: [rt.cpan.org #68916] Solaris with Sun Workshop: heavy cosmetic issue
Date:	Tue, 28 Jun 2011 15:14:17 +0400
To:	<bug-PAR-Packer [...] rt.cpan.org>
From:	Alexander Tokarev <nohuhu [...] nohuhu.org>

The same line is causing trouble again when building with Perl 5.6: it chokes on "${suffix}[]". Changing it to "${suffix}"."[]" does the trick. Regards, Alex. On 6/25/11 7:40 PM, "Roderich Schupp via RT" <bug-PAR-Packer@rt.cpan.org> wrote: Show quoted text

><URL: https://rt.cpan.org/Ticket/Display.html?id=68916 > > >On 2011-06-18 13:49:02, nohuhu@nohuhu.org wrote:

>> print $out "const char ${c_var}${suffix}[] = ";

> >Thanks for reporting, your concerns will be addressed >in the next release of PAR::Packer (all generated byte arrays >will use "unsigned char"). > >Cheers, Roderich

Tue Jun 28 13:53:40 2011 The RT System itself - Status changed from 'patched' to 'open'

Tue Jun 28 15:27:42 2011 RSCHUPP [...] cpan.org - Correspondence added

On 2011-06-28 13:53:39, nohuhu@nohuhu.org wrote: Show quoted text

> The same line is causing trouble again when building with Perl 5.6: it > chokes on "${suffix}[]". Changing it to "${suffix}"."[]" does the trick.

Known bug in Perl 5.6 - simply don't use that stoneage version.

Tue Jun 28 15:27:44 2011 RSCHUPP [...] cpan.org - Status changed from 'open' to 'patched'

Wed Jul 13 10:11:26 2011 RSCHUPP [...] cpan.org - Correspondence added

Fixed in PAR::Packer 1.010

Wed Jul 13 10:11:27 2011 The RT System itself - Status changed from 'patched' to 'open'

Wed Jul 13 10:11:27 2011 RSCHUPP [...] cpan.org - Status changed from 'open' to 'resolved'