Skip Menu |

This queue is for tickets about the MooseX-FollowPBP CPAN distribution.

Report information
The Basics
Id: 68836
Status: resolved
Priority: 0/
Queue: MooseX-FollowPBP
People
Owner: Nobody in particular
Requestors: warman.t.gary [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Jun 15 17:22:27 2011 warman.t.gary [...] gmail.com - Ticket created
Subject: Bug: Attributes with special characters (i.e., -) will not work.
Date: Wed, 15 Jun 2011 16:21:57 -0500
To: bug-moosex-followpbp [...] rt.cpan.org
From: Gary Warman <warman.t.gary [...] gmail.com>
Aloha there! I'm working with MooseX::FollowPBP right now, and I've noticed something. The class that I'm working with has some attributes with dashes in them, because it is interfacing with an XML RPC host that uses those attribute names in the responses. So, I figured it might be in your best interest to consider fixing this. Attached is a diff file for Attribute.pm for a simple patch, replacing special characters with an underscore. No doubt there is a better way to handle it, but I figured it might be a good start. Thank you, Gary Warman Twitter <http://twitter.com/Sir_mXe> | Facebook<http://facebook.com/gary.warman> | LinkedIn <http://www.linkedin.com/in/garywarman> | Website/Blog<http://malformedxmlelement.com/>

Message body is not shown because sender requested not to inline it.

  Wed Jun 15 18:31:18 2011 autarch [...] urth.org - Correspondence added
Subject: Re: [rt.cpan.org #68836] Bug: Attributes with special characters (i.e., -) will not work.
Date: Wed, 15 Jun 2011 17:31:07 -0500 (CDT)
To: Gary Warman via RT <bug-MooseX-FollowPBP [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
On Wed, 15 Jun 2011, Gary Warman via RT wrote: Show quoted text
> I'm working with MooseX::FollowPBP right now, and I've noticed something. > The class that I'm working with has some attributes with dashes in them, > because it is interfacing with an XML RPC host that uses those attribute > names in the responses. So, I figured it might be in your best interest to > consider fixing this. Attached is a diff file for Attribute.pm for a simple > patch, replacing special characters with an underscore. > > No doubt there is a better way to handle it, but I figured it might be a > good start.
This really isn't specific to MX::FollowPBP. It would affect Moose too. I don't think messing with the name is really a good idea. If people use these names, they get what they get. For your code, I'd suggest munging the names _before_ passing them to Moose. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
  Wed Jun 15 18:31:19 2011 The RT System itself - Status changed from 'new' to 'open'
  Wed Jun 15 18:34:16 2011 warman.t.gary [...] gmail.com - Correspondence added
CC:
Subject: Re: [rt.cpan.org #68836] Bug: Attributes with special characters (i.e., -) will not work.
Date: Wed, 15 Jun 2011 15:34:06 -0700 (PDT)
To: bug-MooseX-FollowPBP [...] rt.cpan.org
From: "warman.t.gary [...] gmail.com" <warman.t.gary [...] gmail.com>
Alright. Appreciate the feedback. Cheers. Show quoted text
-----Original Message----- Date: Wednesday, June 15, 2011 5:31:21 pm To: warman.t.gary@gmail.com From: "autarch@urth.org via RT" <bug-MooseX-FollowPBP@rt.cpan.org> Subject: Re: [rt.cpan.org #68836] Bug: Attributes with special characters (i.e., -) will not work. <URL: https://rt.cpan.org/Ticket/Display.html?id=68836 > On Wed, 15 Jun 2011, Gary Warman via RT wrote:
> I'm working with MooseX::FollowPBP right now, and I've noticed something. > The class that I'm working with has some attributes with dashes in them, > because it is interfacing with an XML RPC host that uses those attribute > names in the responses. So, I figured it might be in your best interest to > consider fixing this. Attached is a diff file for Attribute.pm for a simple > patch, replacing special characters with an underscore. > > No doubt there is a better way to handle it, but I figured it might be a > good start.
This really isn't specific to MX::FollowPBP. It would affect Moose too. I don't think messing with the name is really a good idea. If people use these names, they get what they get. For your code, I'd suggest munging the names _before_ passing them to Moose. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
  Wed Jun 22 12:48:20 2011 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'