Bug #68826 for POE-Component-Server-REST: POE::Component::Server::REST 1.03: Extracted key is always empty

-----Original Message----- From: Bugs in POE-Component-Server-REST via RT [mailto:bug-POE-Component-Server-REST@rt.cpan.org] Sent: Wednesday, June 15, 2011 11:16 AM To: Markus Jansen Subject: [rt.cpan.org #68826] AutoReply: POE::Component::Server::REST 1.03: Extracted key is always empty Greetings, This message has been automatically generated in response to the creation of a trouble ticket regarding: "POE::Component::Server::REST 1.03: Extracted key is always empty", a summary of which appears below. There is no need to reply to this message right now. Your ticket has been assigned an ID of [rt.cpan.org #68826]. Your ticket is accessible on the web at: https://rt.cpan.org/Ticket/Display.html?id=68826 Please include the string: [rt.cpan.org #68826] in the subject line of all future correspondence about this issue. To do so, you may reply to this message. Thank you, bug-POE-Component-Server-REST@rt.cpan.org ------------------------------------------------------------------------- Hello Jean, I think I have found a defect in POE::Component::Server::REST 1.03; I simply cannot get a key argument extracted from a URL. The attached patch works (main change in the "unless" line, the others are just a sort of hardening ...). It would be great if you could consider the patch with Component::Server::REST 1.04 (or tell me what I am doing wrong). Best regards, Markus Jansen diff -c /vobs/cc/CCA-perl01/perl5____________________sixtyfive_char_path/prod/lib/site_perl/5.10.1/POE/Component/Server/REST.pm perl5/POE/Component/Server *** /vobs/cc/CCA-perl01/perl5____________________sixtyfive_char_path/prod/lib/site_perl/5.10.1/POE/Component/Server/REST.pm Sat Jun 11 15:52:40 2011 --- perl5/POE/Component/Server/REST.pm Wed Jun 15 11:11:21 2011 *************** *** 547,553 **** # Get the method name my $uri = $request->uri; debug(" requested uri: $uri"); ! unless ( $uri =~ /(\/\D+)(\/\w+)?(\/)?(\?session=(.+))?$/ ) { $kernel->yield( 'FAULT', $response, CLIENT_BADREQUEST, 'Bad Request', "Unrecognized REST url structure: $uri", ); return; } --- 547,553 ---- # Get the method name my $uri = $request->uri; debug(" requested uri: $uri"); ! unless ( $uri =~ /(\/\D+?)(\/\w+)?(\/)?(\?w+=(.+))?$/ ) { $kernel->yield( 'FAULT', $response, CLIENT_BADREQUEST, 'Bad Request', "Unrecognized REST url structure: $uri", ); return; } *************** *** 557,564 **** my $restkey = $2 || ''; # Remove trailing slash ! $method =~ s/\/$//; ! $restkey =~ s/^\///; # Add prefx with given HTTP request method eg. PUT/foo/baz/bar $method = "$type$method"; --- 557,564 ---- my $restkey = $2 || ''; # Remove trailing slash ! $method =~ s,/+$,,; ! $restkey =~ s,^/+,,; # Add prefx with given HTTP request method eg. PUT/foo/baz/bar $method = "$type$method"; Markus Jansen Ericsson GmbH Eurolab R&D Ericsson Allee 1 52134 Herzogenrath, Germany Phone +49 2407 575 5157 Fax +49 22407 575 150 Mobile +49 172 2742003 markus.jansen@ericsson.com www.ericsson.com Ericsson GmbH. Sitz: Düsseldorf. Registergericht: Amtsgericht Düsseldorf, HRB 33012. Geschäftsführer: Stefan Koetz (Vors.), Nils de Baar, Bernd Schmidt. Aufsichtsratsvorsitzender: Anders Runevad. This Communication is confidential. We only send and receive email on the basis of the terms set out at www.ericsson.com/email_disclaimer<http://www.ericsson.com/email_disclaimer>.

> Hi Markus, > > I've implemented a far more sane service/resources/key extraction > version in 1.06 which is currently beeing deployed on CPAN directories. > > Feel free to test it and tell me if it solved your problem.

-----Original Message----- From: Jean Stebens via RT [mailto:bug-POE-Component-Server-REST@rt.cpan.org] Sent: Sunday, June 19, 2011 7:50 PM To: Markus Jansen Subject: [rt.cpan.org #68826] POE::Component::Server::REST 1.03: Extracted key is always empty <URL: https://rt.cpan.org/Ticket/Display.html?id=68826 > On Sun Jun 19 13:48:24 2011, JSTEBENS wrote: For a concrete example, please see the examples/server.pl file - worked perfectly for me :)

> delete /foo/baz/bar [ok] > delete /foo/baz [ok]

> delete /foo/baz [FAIL - cause bar is still active] > delete /foo/baz/bar [ok]