Bug #68797 for CSS-Inliner: Missing newlines at EOF in *

Mon Jun 13 12:14:30 2011 quinnfazigu [...] gmail.com - Ticket created

Subject:

Missing newlines at EOF in *_result.html files

The following files are missing a newline at EOF, causing tests to fail. t/html/acidtest_result.html t/html/linebreaktest_result.html t/html/linktest_result.html

Thu Jun 23 18:55:26 2011 KAMELKEV [...] cpan.org - Correspondence added

Hi, Thanks for your comment. I need more information about the issue you've discovered. For example what platform, version of perl, etc. Many people including myself are using this module and I've never seen an issue related to what you're talking about. I just ran the tests right now and my output is included below. Please note that I am by no means an expert or pro on perl tests - I can barely get them to do what I want. If you see ways of improving it please include patches so I can include them for everyone's benefit. thanks, Kevin Show quoted text

ps> I develop on FreeBSD 8.2 currently, perl 5.10

=================================================================== [kamelkev@w00t CSS-Inliner] date Thu Jun 23 18:51:39 EDT 2011 [kamelkev@w00t CSS-Inliner] make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/acidtest.t t/advanced.t t/advanced_strip.t t/basic.t t/cascade.t t/css_url.t t/custom_html_tree.t t/linebreaktest.t t/linktest.t t/ordering.t t/pod.t t/specificity.t t/acidtest.t .......... ok t/advanced.t .......... ok t/advanced_strip.t .... ok t/basic.t ............. ok t/cascade.t ........... ok t/css_url.t ........... ok t/custom_html_tree.t .. ok t/linebreaktest.t ..... ok t/linktest.t .......... ok t/ordering.t .......... ok t/pod.t ............... ok t/specificity.t ....... ok All tests successful. Files=12, Tests=84, 2 wallclock secs ( 0.02 usr 0.02 sys + 1.02 cusr 0.09 csys = 1.16 CPU) Result: PASS On Mon Jun 13 12:14:30 2011, QuinnFazigu wrote: Show quoted text

> > The following files are missing a newline at EOF, causing tests to fail. > > t/html/acidtest_result.html > t/html/linebreaktest_result.html > t/html/linktest_result.html

Thu Jun 23 18:55:28 2011 The RT System itself - Status changed from 'new' to 'open'

Fri Jun 24 19:43:10 2011 RONS [...] cpan.org - Correspondence added

I probably was editing the files while trying to figure out why they weren't being found and my vim --configure huge option may have included an option to add a newline to files without them. In any case, the latest compiles fine, so you can close this.

Tue Jun 28 13:53:37 2011 quinnfazigu [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #68797] Missing newlines at EOF in *_result.html files
Date:	Fri, 24 Jun 2011 09:30:32 -0400
To:	bug-CSS-Inliner [...] rt.cpan.org
From:	Ronald Straight <quinnfazigu [...] gmail.com>

I appear to be unable to actually modify this bug or do anything else on rt.cpan.org, for that matter. It keeps redirecting me to /Public for any link I click. In any case, this bug can be closed. I downloaded and installed the latest without any issues. It may have been that, while I was trying to figure out why the t/html/ files weren't being loaded, my editor added an extra newline to the files. On Thu, Jun 23, 2011 at 6:55 PM, Kevin Hatim Kamel via RT <bug-CSS-Inliner@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=68797 > > > Hi, > > Thanks for your comment. I need more information about the issue > you've discovered. For example what platform, version of perl, etc. > > Many people including myself are using this module and I've never seen > an issue related to what you're talking about. I just ran the > tests right now and my output is included below. > > Please note that I am by no means an expert or pro on perl tests - I > can barely get them to do what I want. If you see ways of improving it > please include patches so I can include them for everyone's benefit. > > thanks, > Kevin >

> ps> I develop on FreeBSD 8.2 currently, perl 5.10

> > > =================================================================== > > [kamelkev@w00t CSS-Inliner] date > Thu Jun 23 18:51:39 EDT 2011 > [kamelkev@w00t CSS-Inliner] make test > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'blib/lib', 'blib/arch')" t/acidtest.t t/advanced.t > t/advanced_strip.t t/basic.t t/cascade.t t/css_url.t > t/custom_html_tree.t t/linebreaktest.t t/linktest.t t/ordering.t t/pod.t > t/specificity.t > t/acidtest.t .......... ok > t/advanced.t .......... ok > t/advanced_strip.t .... ok > t/basic.t ............. ok > t/cascade.t ........... ok > t/css_url.t ........... ok > t/custom_html_tree.t .. ok > t/linebreaktest.t ..... ok > t/linktest.t .......... ok > t/ordering.t .......... ok > t/pod.t ............... ok > t/specificity.t ....... ok > All tests successful. > Files=12, Tests=84, 2 wallclock secs ( 0.02 usr 0.02 sys + 1.02 cusr > 0.09 csys = 1.16 CPU) > Result: PASS > > > > > > On Mon Jun 13 12:14:30 2011, QuinnFazigu wrote:

>> >> The following files are missing a newline at EOF, causing tests to fail. >> >> t/html/acidtest_result.html >> t/html/linebreaktest_result.html >> t/html/linktest_result.html

> > > >

Fri Jul 22 15:35:24 2011 KAMELKEV [...] cpan.org - Correspondence added

Ok. Try the new version, more bugs fixed!

Fri Jul 22 15:35:25 2011 KAMELKEV [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #68797 for CSS-Inliner: Missing newlines at EOF in *_result.html files