Skip Menu |

This queue is for tickets about the Bot-Infobot CPAN distribution.

Report information
The Basics
Id: 68767
Status: resolved
Priority: 0/
Queue: Bot-Infobot

People
Owner: Nobody in particular
Requestors: BABAR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.9
Fixed in: (no value)



Subject: infobot doesn't load modules properly
Documentation states: [Foo] somevar = a value The plugin Bot::BasicBot::Pluggable::Module::Foo will have the variable somevar set a value. But this is broken, and the following patch fixes it (and uses ->load to load a module): --- /usr/local/bin/infobot 2011-06-11 19:36:51.000000000 +0000 +++ /home/bot/InfoBot/infobot 2011-06-11 23:32:40.000000000 +0000 @@ -200,8 +200,8 @@ # Then set the keys the plugins foreach my $key (keys %conf) { next if $key eq 'store'; - next unless ref $key eq 'HASH'; - my $mod = $bot->module($key); + next unless ref $conf{$key} eq 'HASH'; + my $mod = $bot->load($key); unless (defined $mod) {
Fixed in git commit 12126014e5732bb3bf72868aacaf060568665734 will be released as 1.0
Err, my mistake, fixed in git commit 9eef5db83e7bbb0e7ab069d02237de0c61cf61a9