Bug #68679 for ExtUtils-MakeMaker: dmake on win32 (strawberry) doesn't like escaped CCFLAGS

On Tue Jun 07 06:34:23 2011, alex@earth.li wrote: Show quoted text
This is a less violent way as it leaves alone () not in quotes, which I think is sensible, it should manage to only mess with quoted stuff, I also have some tests for the included little function(below the patch), but I'm not sure which test file to put them in. --- ExtUtils-MakeMaker-6.57_11/lib/ExtUtils/MM_Unix.pm Fri May 20 12:27:11 2011 +++ ../ExtUtils-MakeMaker-6.57_11/lib/ExtUtils/MM_Unix.pm Tue Jun 7 23:23:52 2011 @@ -264,8 +264,14 @@ $pollute = '$(PERL_MALLOC_DEF)'; } - $self->{CCFLAGS} = quote_paren($self->{CCFLAGS}); - $self->{OPTIMIZE} = quote_paren($self->{OPTIMIZE}); + if ($Config{make} eq 'dmake') { + $self->{CCFLAGS} = quote_paren_not_quoted($self->{CCFLAGS}); + $self->{OPTIMIZE} = quote_paren_not_quoted($self->{OPTIMIZE}); + } + else { + $self->{CCFLAGS} = quote_paren($self->{CCFLAGS}); + $self->{OPTIMIZE} = quote_paren($self->{OPTIMIZE}); + } return $self->{CFLAGS} = qq{ CCFLAGS = $self->{CCFLAGS} @@ -3089,6 +3095,31 @@ $arg =~ s{(?<!\\)([()])}{\\$1}g; # quote unprotected $arg =~ s{\$\\\\\((.+?)\\\\\)}{\$($1)}g; # unprotect $(...) return $arg; +} + +=item quote_paren_not_quoted + +Backslashes parentheses C<()> in command line arguments. +Doesn't handle recursive Makefile C<$(...)> constructs, +but handles simple ones. Leaves alone anything in unprotected +quotes. + +=cut + +sub quote_paren_not_quoted { + my $arg = shift; + my @parts = split(/(?<!\\)(")/, $arg); + push(@parts, '') if (substr($arg, -1, 1) eq q{"}); + + if (@parts == 1) { + return quote_paren($arg); + } + else { + for my $i (0..@parts-1) { + $parts[$i] = quote_paren($parts[$i]) if $i % 4 == 0; + } + return join(q{}, @parts); + } } =item replace_manpage_separator ############################ Tests: is(quote_paren_not_quoted(q{}), q{}); is(quote_paren_not_quoted(q{()}), q{\\(\\)}); is(quote_paren_not_quoted(q{"()"}), q{"()"}); is(quote_paren_not_quoted(q{()""()}), q{\\(\\)""\\(\\)}); is(quote_paren_not_quoted(q{"()""()"}), q{"()""()"}); is(quote_paren_not_quoted(q{"()" ("}), q{"()" \\("}); is(quote_paren_not_quoted(q{"\\""}), q{"\\""}); is(quote_paren_not_quoted(q{"(\\"("}), q{"(\\"("}); is(quote_paren_not_quoted(q{"(\\"(" ( ""}), q{"(\\"(" \\( ""}); is(quote_paren_not_quoted(q{\\" () \\"}), q{\\" \\(\\) \\"}); is(quote_paren_not_quoted(q{"\\" () \\""}), q{"\\" () \\""});

On Sun Sep 25 02:11:30 2011, MSCHWERN wrote: Show quoted text
That still has the problem, I'll see if I have time to investigate further later. This isn't a showstopper as the obvious workaround is to install my libraries in a path without spaces. perl -MExtUtils::MakeMaker -E "say $ExtUtils::MakeMaker::VERSION" 6.6101 (With Parallel::MPI::Simple) perl MakeFile.PL ... ok dmake .... C:\strawberry\perl\bin\perl.exe C:\strawberry\perl\lib\ExtUtils\xsubpp -typemap C:\strawberry\perl\lib\ExtUtils\typemap Simple.xs > Simple .xsc && C:\strawberry\perl\bin\perl.exe -MExtUtils::Command -e mv -- Simple.xsc Simple.c gcc -c "-IC:\Program Files \(x86\)\MPICH2\include" "- LC:\Program Files \(x86\)\MPICH2\lib" -lmpi -s -O2 - DVERSION=\"0.10\" -DXS_VERSION=\"0.10\" "-IC:\strawberry\perl\lib\CORE" Simple.c Simple.xs:8:18: error: mpi.h: No such file or directory

Thanks for checking it out and the repatch. Let me see if our Resident Expert on Windows quoting will weigh in, otherwise ping the bug in a few days and I'll patch it in.

On 2011.9.28 3:43 PM, Steve Hay via RT wrote: Show quoted text
Paths with spaces in them are caveat emptor, but a user has less control over where C libraries are located on Windows than where Perl is so I'm a bit more sympathetic. Show quoted text
I'm opening this as a separate issue. https://rt.cpan.org/Ticket/Display.html?id=71325 -- Anyway, last I saw him, the TPF goons were pouring concrete around him, leaving only one hole each for air, tea, and power. No ethernet, because he's using git. -- Eric Wilhelm on one of my disappearances

Thanks for the analysis. Patching it in, I've noticed this applies to MM_Unix, so it will affect all platforms. Is that safe? The basic logic makes sense, escape parens unless it's quoted, but the quotes are different on Unix which I can account for in the patch. Also, what's doing the quoting? Are they already quoted in $Config{ccflags}?

On Sat Oct 01 02:57:33 2011, schwern@pobox.com wrote: Show quoted text
I have no idea about other platforms, so I can't help there :-( Show quoted text
In the test case that I hacked together I explicitly passed CCFLAGS => with a string already containing quotes (double-quotes in my case, on Windows) to the WriteMakefile() call. Alex's Parallel-MPI-Simple distro did likewise (see http://cpansearch.perl.org/src/AJGOUGH/Parallel-MPI-Simple-0.10/Makefile.PL). So MM_Unix.pm's $self->{CCFLAGS} is certainly already quoted in these cases, but I don't know about $Config{ccflags}... My Config_heavy.pl contains ccflags='-nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DPERL_MSVCRT_READFIX' It has no -I or -L include or library paths that might need quoting. I thought we were only talking about the paths of libraries that extension modules may need to link against, so why would such paths ever appear in $Config{ccflags}? Surely that would only ever contain paths related to the original perl build, which should never need quoting since we do not support paths with spaces for that. Btw, I find the function names quote_paren() and quote_paren_if_not_quoted() rather confusing -- especially the latter! Are they really "quoting" parentheses? To my mind "quoting" something is adding double-quotes (") or single-quotes (') around it; what we're doing here is *escaping* parentheses with a preceding backslash. Perhaps escape_paren() and escape_paren_unless_quoted() would be better names?