Bug #68607 for DateTime-TimeZone-Local-Win32: Windows Server 2008/Vista time zone residual cases still fail

Thu Jun 02 10:04:49 2011 stuart [...] morungos.com - Ticket created

Subject:

Windows Server 2008/Vista time zone residual cases still fail

The issue in ticket 35733 still exists in a few cases. This was the Windows Server 2008/Vista time zone detection issue. A colleague of mine has found a case where the registry get returned in DateTime::TimeZone::Local::Win32 is not properly cleaned following a null. This is because $win_name =~ s/\0.*$// doesn't handle the case where there is a newline in the data after the null. Multiple nulls and newlines are also like to return invalid values. It probably ought to be: $win_name =~ s/\0.*$//s or even an index and substr combination, given that the $win_name appears to be a mix of text and binary data.

Wed Jun 22 12:11:16 2011 DROLSKY [...] cpan.org - Correspondence added

RT-Send-CC:

David.Pinkowitz [...] numarasoftware.com

There's a sort of vague plan to move the Win32 time zone bits to its own distro. I've cc'd David Pinkowitz, who is the person I hope will take that on. I think any future Win32 bug fixes should go into said notional distro.

Wed Jun 22 12:11:17 2011 The RT System itself - Status changed from 'new' to 'open'

Wed Jun 22 12:30:48 2011 stuart [...] morungos.com - Correspondence added

Subject:	Re: [rt.cpan.org #68607] Windows Server 2008/Vista time zone residual cases still fail
Date:	Wed, 22 Jun 2011 12:30:32 -0400
To:	bug-DateTime-TimeZone [...] rt.cpan.org
From:	Stuart Watt <stuart [...] morungos.com>

On 11-06-22 12:11 PM, Dave Rolsky via RT wrote: Sounds good. We've made a local patch for now, so we can live with it. I suspect a few other servers might be vulnerable to this recurrence of the earlier issue, but hopefully not too many. Let me know if I can help, I've been a Windows Perl dev for a good while, so I'm happy to assist. All the best Stuart Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=68607> > > There's a sort of vague plan to move the Win32 time zone bits to its own > distro. I've cc'd David Pinkowitz, who is the person I hope will take > that on. > > I think any future Win32 bug fixes should go into said notional distro.

Wed Jun 22 12:36:07 2011 autarch [...] urth.org - Correspondence added

Subject:	Re: [rt.cpan.org #68607] Windows Server 2008/Vista time zone residual cases still fail
Date:	Wed, 22 Jun 2011 11:35:56 -0500 (CDT)
To:	Stuart Watt via RT <bug-DateTime-TimeZone [...] rt.cpan.org>
From:	Dave Rolsky <autarch [...] urth.org>

On Wed, 22 Jun 2011, Stuart Watt via RT wrote: Show quoted text

> Sounds good. We've made a local patch for now, so we can live with it. I > suspect a few other servers might be vulnerable to this recurrence of > the earlier issue, but hopefully not too many. > > Let me know if I can help, I've been a Windows Perl dev for a good > while, so I'm happy to assist.

Basically, the task is to extract DateTime::TimeZone::Local::Win32 into it's own module and make sure that DT::TZ itself continues to work fine. The DT::TZ::HPUX distro is a good example of this. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/

Mon Nov 17 01:00:24 2014 DROLSKY [...] cpan.org - Queue changed from DateTime-TimeZone to DateTime-TimeZone-Local-Win32

Thu Feb 19 00:07:38 2015 DAPINK [...] cpan.org - Taken

Thu Feb 19 08:39:56 2015 DAPINK [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Feb 19 08:39:58 2015 DAPINK [...] cpan.org - Fixed in 1.81 added