| Subject: | Test suite fails with old Test::More versions |
The workaround in coretests.pm for use_ok with old Test::More versions
seems to be expecting an exact version match rather than "at least" the
requested version. This leads to the following failure with 0.89:
$ make test
make[1]: Entering directory `/builddir/build/BUILD/version-0.89/vutil'
make[1]: Leaving directory `/builddir/build/BUILD/version-0.89/vutil'
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01base..........# Failed test (t/coretests.pm at line 15)
# got: '0.89'
# expected: '0.88'
# Looks like you failed 1 tests of 535.
dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 1
Failed 1/535 tests, 99.81% okay (less 8 skipped tests: 526 okay,
98.32%)
t/02derived.......# Failed test (t/coretests.pm at line 15)
# got: '0.89'
# expected: '0.88'
# Looks like you failed 1 tests of 549.
dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 1
Failed 1/549 tests, 99.82% okay (less 8 skipped tests: 540 okay,
98.36%)
t/03require.......ok
18/270 skipped: various reasons
t/04strict_lax....ok
Failed 2/4 test scripts, 50.00% okay. 2/1526 subtests failed, 99.87% okay.
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
t/01base.t 1 256 535 1 0.19% 1
t/02derived.t 1 256 549 1 0.18% 1
34 subtests skipped.
make: *** [test_dynamic] Error 29
Attached patch works around this by changing the expected version from
0.88 to 0.89 but a better fix would be to fix the coretests.pm to accept
higher versions, as per Test::More itself.
| Subject: | version-0.89-version.patch |
diff -up version-0.89/t/01base.t.orig version-0.89/t/01base.t
--- version-0.89/t/01base.t.orig 2010-12-19 20:16:08.000000000 +0000
+++ version-0.89/t/01base.t 2011-05-31 19:47:59.832677144 +0100
@@ -9,7 +9,7 @@ my $Verbose;
BEGIN {
require "t/coretests.pm";
- use_ok('version', 0.88);
+ use_ok('version', 0.89);
}
diag "Tests with base class" if $Verbose;
diff -up version-0.89/t/02derived.t.orig version-0.89/t/02derived.t
--- version-0.89/t/02derived.t.orig 2011-05-31 11:29:28.000000000 +0100
+++ version-0.89/t/02derived.t 2011-05-31 19:47:38.004774939 +0100
@@ -10,7 +10,7 @@ my $Verbose;
BEGIN {
require "t/coretests.pm";
- use_ok("version", 0.88);
+ use_ok("version", 0.89);
# If we made it this far, we are ok.
}