Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Data-Printer CPAN distribution.

Report information
The Basics
Id: 68567
Status: resolved
Priority: 0/
Queue: Data-Printer
People
Owner: Nobody in particular
Requestors: RANDIR [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.16

History Show all quoted text
  Tue May 31 09:01:24 2011 RANDIR [...] cpan.org - Ticket created
Subject: Fails to load on 5.8.8
First, thanks for a great module) There's a patch in attachment, that makes it work on 5.8.8.
Subject: data-printer.diff
--- lib/Data/Printer.pm.old 2011-05-31 16:52:49.000000000 +0400 +++ lib/Data/Printer.pm 2011-05-31 16:51:52.000000000 +0400 @@ -289,8 +289,8 @@ eval { if (my $flags = fcntl($$item, F_GETFL, 0) ) { - $extra .= $flags & O_WRONLY ? 'write-only' - : $flags & O_RDWR ? 'read/write' + $extra .= ($flags & O_WRONLY) ? 'write-only' + : ($flags & O_RDWR) ? 'read/write' : 'read-only' ;
  Tue May 31 11:13:46 2011 garu [...] cpan.org - Correspondence added
On Tue May 31 09:01:24 2011, RANDIR wrote: Show quoted text
> First, thanks for a great module) There's a patch in attachment, that > makes it work on 5.8.8.
Great! Just shipped 0.16 with your patch, should hit CPAN anytime soon. Thank you very much!
  Tue May 31 11:13:46 2011 The RT System itself - Status changed from 'new' to 'open'
  Tue May 31 11:13:46 2011 garu [...] cpan.org - Status changed from 'open' to 'patched'
  Thu Jun 09 00:46:45 2011 garu [...] cpan.org - Correspondence added
On Tue May 31 11:13:46 2011, GARU wrote: Show quoted text
> On Tue May 31 09:01:24 2011, RANDIR wrote:
> > First, thanks for a great module) There's a patch in attachment, that > > makes it work on 5.8.8.
> > Great! Just shipped 0.16 with your patch, should hit CPAN anytime soon. > > Thank you very much!
I just tested 0.19 on 5.8.9 and it works rather nicely. Can you confirm this is solved for 5.8.8 so we can close the ticket? Thanks again!
  Thu Jun 09 00:46:45 2011 The RT System itself - Status changed from 'patched' to 'open'
  Tue Jun 14 04:37:46 2011 RANDIR [...] cpan.org - Correspondence added
Yes, it has been fixed. Thanks.
  Tue Jun 14 09:26:34 2011 garu [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Jun 14 09:26:35 2011 garu [...] cpan.org - Fixed in 0.16 added