Bug #6856 for Maypole: syntax problems in search in CDBI.pm

Tue Jul 06 01:53:58 2004 JESTER [...] cpan.org - Ticket created

Subject:

syntax problems in search in CDBI.pm

The search method in CDBI.pm has errors in the bit that generates the search itself; the method does not use correct syntax according to the CDBI::AbstractSearch docs. The proper line should be: $r->objects([ $self->search_where(\%values, ($order ? { order_by => $order } : {})) ]);

Wed Nov 24 17:17:28 2004 SIMONFLK [...] cpan.org - Correspondence added

The order parameter is deprected but still works in the most recent version of CDBI::AbstractSearch. The next release will use the documented parameter 'order_by'. Thanks --simonflk

Wed Nov 24 17:17:29 2004 SIMONFLK [...] cpan.org - Status changed from 'new' to 'resolved'

Wed Nov 24 17:58:31 2004 JESTER [...] cpan.org - Correspondence added

[SIMONFLK - Wed Nov 24 17:17:28 2004]: Show quoted text

> The order parameter is deprected but still works in the most recent > version of CDBI::AbstractSearch. The next release will use the > documented parameter 'order_by'.

That wasn't the main problem; there really was a syntax error with how the order param was passed. You'll see that the, say, 1.7 release has something like $self->search_where(\%values), ($order... where it's clear that the "order" stuff needs to be within the parens enclosing the search_where params. This has already been fixed in the current release. The use of "order_by" in place of the deprecated "order" was an additional and minor issue, but best to fix it too. Thanks.

Wed Nov 24 17:58:34 2004 The RT System itself - Status changed from 'resolved' to 'open'

Wed Nov 24 18:14:03 2004 SIMONFLK [...] cpan.org - Correspondence added

[JESTER - Wed Nov 24 17:58:31 2004]: Show quoted text

> That wasn't the main problem; there really was a syntax error with how > the order param was passed. > > You'll see that the, say, 1.7 release has something like > > $self->search_where(\%values), ($order...

Ahh yes, I see. Show quoted text

> This has already been fixed in the current release.

I can close this then! Simon

Wed Nov 24 18:14:48 2004 SIMONFLK [...] cpan.org - Status changed from 'open' to 'resolved'