Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 68557
Status: resolved
Priority: 0/
Queue: Net-DNS

People
Owner: Nobody in particular
Requestors: ABH [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.66
Fixed in: (no value)



Subject: Net::DNS::Nameserver crash on invalid query
Occasionally (every few million queries) Net::DNS::Nameserver crashes on line 387 with "can't call additional on undefined variable". It seems like this originates earlier with: my $query = Net::DNS::Packet->new(\$buf); my $conn = { sockhost => $sock->sockhost, sockport => $sock->sockport, peerhost => $sock->peerhost, peerport => $sock->peerport }; my $reply = $self->make_reply($query, $peerhost, $conn) || return; my $max_len = $self->max_udp_len($query); ... some of this code should probably bail out / return if $query doesn't get setup.
Hi ABH, This is already fixed in the current trunk. Best regards, Willem On Mon May 30 23:51:13 2011, ABH wrote: Show quoted text
> Occasionally (every few million queries) Net::DNS::Nameserver crashes > on line 387 with "can't > call additional on undefined variable". It seems like this originates > earlier with: > > my $query = Net::DNS::Packet->new(\$buf); > my $conn = { > sockhost => $sock->sockhost, > sockport => $sock->sockport, > peerhost => $sock->peerhost, > peerport => $sock->peerport > }; > my $reply = $self->make_reply($query, $peerhost, $conn) || return; > my $max_len = $self->max_udp_len($query); > > ... some of this code should probably bail out / return if $query > doesn't get setup. > >
On Tue May 31 03:29:33 2011, WILLEM wrote: Show quoted text
> Hi ABH, > > This is already fixed in the current trunk. >
Hi Willem, Great! Any plans for pushing it out in a release? - ask
I promise to do a release well before the last week of July (when my vacation starts). Cheers, Willem On Sat Jun 04 02:00:49 2011, ABH wrote: Show quoted text
> On Tue May 31 03:29:33 2011, WILLEM wrote:
> > Hi ABH, > > > > This is already fixed in the current trunk. > >
> > Hi Willem, > > Great! Any plans for pushing it out in a release? > > > - ask