Bug #68464 for minismokebox: Doesn't honour PERL5LIB

Wed May 25 09:36:17 2011 njh [...] bandsman.co.uk - Ticket created

Subject:

Doesn't honour PERL5LIB

On some machines I get this error: The specified perl '/usr/bin/perl' does not have backend 'CPAN::Reporter' installed, aborting Which is not true: nigel:~ nigel$ perl -MCPAN -eshell cpan shell -- CPAN exploration and modules installation (v1.9600) Enter 'h' for help. cpan[1]> install CPAN::Reporter CPAN: Storable loaded ok (v2.25) Going to read '/Users/nigel/.cpan/Metadata' Database was generated on Mon, 23 May 2011 13:34:44 GMT CPAN: LWP::UserAgent loaded ok (v6.02) CPAN: Time::HiRes loaded ok (v1.9722) Fetching with LWP: ftp://cpan.hexten.net/authors/01mailrc.txt.gz CPAN: YAML::XS loaded ok (v0.35) Going to read '/Users/nigel/.cpan/sources/authors/01mailrc.txt.gz' CPAN: Compress::Zlib loaded ok (v2.033) Going to read 46 yaml files from /Users/nigel/.cpan/build/ ......................................................................DONE Restored the state of 1 (in 0.3511 secs) ............................................................................DONE Fetching with LWP: ftp://cpan.hexten.net/modules/02packages.details.txt.gz Going to read '/Users/nigel/.cpan/sources/modules/02packages.details.txt.gz' Database was generated on Wed, 25 May 2011 12:27:54 GMT ............................................................................DONE Fetching with LWP: ftp://cpan.hexten.net/modules/03modlist.data.gz Going to read '/Users/nigel/.cpan/sources/modules/03modlist.data.gz' ............................................................................DONE Going to write /Users/nigel/.cpan/Metadata CPAN: Module::CoreList loaded ok (v2.49) CPAN::Reporter is up to date (1.1902). cpan[2]> The problem appears to be that minismokebox doesn't honour PERL5LIB, I have CPAN::Reporter installed in a non standard directory. nigel:~ nigel$ echo $PERL5LIB /Users/nigel/perl/Library/Perl/Updates/5.10.0:/Users/nigel/perl/Users/nigel/perl::/Users/nigel/perl/lib/perl5:/Users/nigel/perl/lib/perl5/site_perl: nigel:~ nigel$

Wed May 25 17:35:21 2011 chris [...] bingosnet.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #68464] Doesn't honour PERL5LIB
Date:	Wed, 25 May 2011 22:35:05 +0100
To:	"njh [...] bandsman.co.uk via RT" <bug-minismokebox [...] rt.cpan.org>
From:	"Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>

On Wed, May 25, 2011 at 09:36:18AM -0400, njh@bandsman.co.uk via RT wrote: Show quoted text

> > The problem appears to be that minismokebox doesn't honour PERL5LIB, I > have CPAN::Reporter installed in a non standard directory. > > nigel:~ nigel$ echo $PERL5LIB > /Users/nigel/perl/Library/Perl/Updates/5.10.0:/Users/nigel/perl/Users/nigel/perl::/Users/nigel/perl/lib/perl5:/Users/nigel/perl/lib/perl5/site_perl: > nigel:~ nigel$ >

Hi, POE::Component::SmokeBox::Backend which minismokebox uses behind the scenes to fork the 'smoker' process sanctifies the environment for the forked process. <snip> my $sanctify = Env::Sanctify->sanctify( env => $self->{env}, sanctify => [ '^POE_', '^PERL5_SMOKEBOX', '^HARNESS_', '^(PERL5LIB|TAP_VERSION|TEST_VERBOSE)$', '^AUTHOR_TESTING$', '^PERL_TEST', ] ); </snip> This was to stop possible perl related environment variables that applied to the perl that was controlling the smoker process leaking into the smoker environment. Luckily, I did consider that one might need to tailor the smoker environment. Unfortunately, I didn't add this as a configuration option to minismokebox. I've just uploaded version 0.46 which allows one to add environment variables to the configuration file that are passed to the forked smoker process. Cheers, -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================

Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.

Wed May 25 17:35:22 2011 The RT System itself - Status changed from 'new' to 'open'

Thu May 26 11:20:41 2011 njh [...] bandsman.co.uk - Correspondence added

From:

njh [...] bandsman.co.uk

Chris, Thanks for the update. I'm sorry to say that with 0.46 I get the same error: /usr/bin/perl5.10.0 perl/bin/minismokebox --perl /usr/bin/perl5.10.0 --backend CPAN::Reporter --url ftp://cpan.hexten.net/ Running minismokebox with options: perl /usr/bin/perl backend CPAN::Reporter url ftp://cpan.hexten.net/ The specified perl '/usr/bin/perl' does not have backend 'CPAN::Reporter' installed, aborting minismokebox started at: Thu May 26 11:14:54 2011 minismokebox finished at: Thu May 26 11:14:54 2011 minismokebox ran for: 0 seconds minismokebox tot jobs: 0 minismokebox avg run: 0 seconds minismokebox min run: 0 seconds minismokebox max run: 0 seconds Use of uninitialized value in hash element at /Users/nigel/perl/lib/perl5/site_perl/App/SmokeBox/Mini.pm line 242.

Fri Jun 03 08:23:34 2011 chris [...] bingosnet.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #68464] Doesn't honour PERL5LIB
Date:	Fri, 3 Jun 2011 13:23:24 +0100
To:	"njh [...] bandsman.co.uk via RT" <bug-minismokebox [...] rt.cpan.org>
From:	"Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>

On Thu, May 26, 2011 at 11:20:42AM -0400, njh@bandsman.co.uk via RT wrote: Show quoted text

> Queue: minismokebox > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=68464 > > > Chris, > > Thanks for the update. I'm sorry to say that with 0.46 I get the same > error: > > /usr/bin/perl5.10.0 perl/bin/minismokebox --perl /usr/bin/perl5.10.0 > --backend CPAN::Reporter --url ftp://cpan.hexten.net/ > Running minismokebox with options: > perl /usr/bin/perl > backend CPAN::Reporter > url ftp://cpan.hexten.net/ > The specified perl '/usr/bin/perl' does not have backend > 'CPAN::Reporter' installed, aborting > minismokebox started at: Thu May 26 11:14:54 2011 > minismokebox finished at: Thu May 26 11:14:54 2011 > minismokebox ran for: 0 seconds > minismokebox tot jobs: 0 > minismokebox avg run: 0 seconds > minismokebox min run: 0 seconds > minismokebox max run: 0 seconds > Use of uninitialized value in hash element at > /Users/nigel/perl/lib/perl5/site_perl/App/SmokeBox/Mini.pm line 242.

I added a test for the behaviour and if PERL5LIB is specified in the configuration file it definitely gets set when the backend is forked. In the minismokebox configuration something like: [ENVIRONMENT] PERL5LIB=/some/path/here:/and/another/one Alternatively I have added the --perlenv switch to minismokebox itself. If you specify this it will pass PERL5LIB through if it exists in the environment when minismokebox is run. Cheers, -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================

Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.

Fri Jun 03 13:44:30 2011 njh [...] bandsman.co.uk - Correspondence added

From:

njh [...] bandsman.co.uk

My mistake - the fix does work, thanks. I missed that the 0.50 installation failed because of RT68608.

Wed Jun 08 10:46:29 2011 njh [...] bandsman.co.uk - Correspondence added

From:

njh [...] bandsman.co.uk

Show quoted text

> sanctify => [ > '^POE_', > '^PERL5_SMOKEBOX', > '^HARNESS_', > '^(PERL5LIB|TAP_VERSION|TEST_VERBOSE)$', > '^AUTHOR_TESTING$', > '^PERL_TEST', > ] ); > </snip>

Please add LDFLAGS and LDDFLAGS to get around the OS/X problem documented at http://perlnews.org/2011/04/dealing-with-xcode-4-and-cpan-breakage/#comment-402

Thu Jun 09 05:02:28 2011 chris [...] bingosnet.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #68464] Doesn't honour PERL5LIB
Date:	Thu, 9 Jun 2011 10:00:28 +0100
To:	"njh [...] bandsman.co.uk via RT" <bug-minismokebox [...] rt.cpan.org>
From:	"Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>

On Wed, Jun 08, 2011 at 10:46:29AM -0400, njh@bandsman.co.uk via RT wrote: Show quoted text

> Queue: minismokebox > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=68464 > > >

> > sanctify => [ > > '^POE_', > > '^PERL5_SMOKEBOX', > > '^HARNESS_', > > '^(PERL5LIB|TAP_VERSION|TEST_VERBOSE)$', > > '^AUTHOR_TESTING$', > > '^PERL_TEST', > > ] ); > > </snip>

> > Please add LDFLAGS and LDDFLAGS to get around the OS/X problem > documented at > http://perlnews.org/2011/04/dealing-with-xcode-4-and-cpan-breakage/#comment-402 >

Hi, Can I just check what you want. I'm reading this as: "Can you add LDFLAGS and LDDLFLAGS to the environment variables that are removed from the environment that smoker processes run in" Can you confirm this is your intention ? Many thanks. -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================

Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.

Thu Jun 09 09:56:59 2011 njh [...] bandsman.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #68464] Doesn't honour PERL5LIB
Date:	Thu, 9 Jun 2011 09:56:37 -0400
To:	bug-minismokebox [...] rt.cpan.org
From:	Nigel Horne <njh [...] bandsman.co.uk>

On 9 Jun 2011, at 05:02, chris@bingosnet.co.uk via RT wrote: Show quoted text

>>>

>> >> Please add LDFLAGS and LDDFLAGS to get around the OS/X problem >> documented at >> http://perlnews.org/2011/04/dealing-with-xcode-4-and-cpan-breakage/#comment-402 >>

> > Hi, > > Can I just check what you want. I'm reading this as: > > "Can you add LDFLAGS and LDDLFLAGS to the environment variables that are > removed from the environment that smoker processes run in" > > Can you confirm this is your intention ?

No - the opposite, can you please ensure that they are passed though. If they are already then no action is needed. Thanks, -Nigel