Skip Menu |

This queue is for tickets about the Geo-Coder-Googlev3 CPAN distribution.

Report information
The Basics
Id: 68437
Status: resolved
Priority: 0/
Queue: Geo-Coder-Googlev3

People
Owner: Nobody in particular
Requestors: kaoru [...] slackwise.net
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.07
Fixed in: (no value)



It looks like the test location "Berliner Straße, Berlin, Germany" no longer returns more than one result from Google's API. I fixed this by changing the location to "Waterloo, UK", which returns many results. Patch attached.
Subject: fix_geocode_test.patch
--- ./t/geocode.t 2011-03-01 21:21:42.000000000 +0000 +++ ./t/geocode.t 2011-05-24 10:55:23.000000000 +0100 @@ -13,9 +13,9 @@ isa_ok $geocoder, 'Geo::Coder::Googlev3'; { # list context - my @locations = $geocoder->geocode(location => 'Berliner Straße, Berlin, Germany'); + my @locations = $geocoder->geocode(location => 'Waterloo, UK'); cmp_ok scalar(@locations), ">", 1, "More than one result found"; # There are eight hits in Berlin, Google knows seven of them - like $locations[0]->{formatted_address}, qr{Berliner Straße}, 'First result looks OK'; + like $locations[0]->{formatted_address}, qr{Waterloo, Lambeth}, 'First result looks OK'; } {
On 2011-05-24 06:16:49, KAORU wrote: Show quoted text
> It looks like the test location "Berliner Straße, Berlin, Germany" no > longer returns more than one result from Google's API. > > I fixed this by changing the location to "Waterloo, UK", which returns > many results. > > Patch attached.
Thanks, fixed in 0.08. Regards, Slaven