| Date: | Wed, 29 May 2002 16:20:55 -0600 (MDT) |
| From: | Rob Brown <rob [...] roobik.com> |
| To: | via RT <bug-Net-Ping [...] rt.cpan.org> |
| Subject: | Re: Net::Ping tests (fwd) |
Resending bounced message
Show quoted text
---------- Forwarded message ----------
Date: Sun, 17 Feb 2002 19:55:42 -0700 (MST)
From: Rob Brown <rob@roobik.com>
To: Jarkko Hietaniemi <jhi@iki.fi>
Cc: perl5-porters@perl.org, Craig A. Berry <craigberry@mac.com>, bbb@cpan.org,
arnaud@romeconcept.com, via RT <bug-Net-Ping@rt.cpan.org>
Subject: Re: Net::Ping tests
On Sat, 16 Feb 2002, Jarkko Hietaniemi wrote:
> On Mon, Feb 04, 2002 at 11:07:13PM -0600, Craig A. Berry wrote:
Jarkko:
I forgot to commit it into my cvs tree. Sorry about
that. I did not apply Craig's patches into the Ping.pm
code because of potential performance issues for real
execution, but let me know what you think is most
appropriate. I changed the version to 2.12 and
uploaded to CPAN again. The tests should clear now.
Mr "via RT":
Sorry about hard coding the error strings in there.
The tests should also work with your French settings
now, too. :-)
connect: Connexion refusée
-- Rob
> > At 12:17 PM -0700 2/2/02, Rob Brown wrote:
> >
>
> Net::Ping 2.11 doesn't seem to contain this patch.
> > >I put an echo check in the BEGIN block of the
> > >tests that would fail, then I wiped "echo" from
> > >my /etc/services file to test it. It now passes
> > >(skips) when echo service is not available.
> > >Download Net::Ping 2.11 from CPAN and try again.
> >
> > Thanks Rob, that seems to do the trick as far as echo goes. The icmp
> > test fails without privs (rather than getting skipped). The
> > following looks a bit messy (and doesn't necessarily cover all
> > privileges that would potentially allow one to do icmp) but it's the
> > best approximation to checking for root that I could come up
> > with.
> >
> > --- t/110_icmp_inst.t;-0 Sat Jan 5 15:18:19 2002
> > +++ t/110_icmp_inst.t Mon Feb 4 22:49:03 2002
> > @@ -15,7 +15,9 @@
> > # Everything loaded fine
> > ok 1;
> >
> > -if ($> and $^O ne 'VMS') {
> > +if (($> and $^O ne 'VMS')
> > + or ($^O eq 'VMS'
> > + and (`write sys\$output f\$privilege("SYSPRV")` =~ m/FALSE/))) {
> > skip "icmp ping requires root privileges.", 1;
> > } else {
> > my $p = new Net::Ping "icmp";
> > [end]