Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 68338
Status: resolved
Priority: 0/
Queue: Net-DNS

People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.66
Fixed in: (no value)



Subject: qw() deprecation warnings in perl 5.14
The following warnings happen when running the test suite in perl 5.14. Use of qw(...) as parentheses is deprecated at t/04-packet.t line 43. Use of qw(...) as parentheses is deprecated at t/05-apl.t line 16. Use of qw(...) as parentheses is deprecated at t/05-apl.t line 21.
This patch should resolve things.
Subject: patch.txt
commit e9afa5672fcf25fcacb6cac4e02de8c04f620884 Author: Todd Rinaldo <toddr@cpanel.net> Date: Fri May 20 02:09:24 2011 -0500 Fix for RT 68338 - Fix deprecated qw() message for Net-DNS diff --git a/t/04-packet.t b/t/04-packet.t index 5b5a73e..818afaa 100644 --- a/t/04-packet.t +++ b/t/04-packet.t @@ -40,7 +40,7 @@ foreach my $method ( qw(question answer authority additional) ) { } # Default question added to empty packet -my $default = Net::DNS::Question->new qw(. ANY ANY); +my $default = Net::DNS::Question->new(qw(. ANY ANY)); ok($empty->data, 'packet->data() method works'); my ($implicit) = $empty->question; is($implicit->string, $default->string, 'implicit question in empty packet' ); diff --git a/t/05-apl.t b/t/05-apl.t index 3702bdf..5696091 100644 --- a/t/05-apl.t +++ b/t/05-apl.t @@ -13,12 +13,12 @@ use Net::DNS::RR::APL; -foreach my $apitem qw( 1:192.168.32.0/21 !1:192.168.32.0/21 2:FF00:0:0:0:0:0:0:0/8){ +foreach my $apitem ( qw( 1:192.168.32.0/21 !1:192.168.32.0/21 2:FF00:0:0:0:0:0:0:0/8) ) { my $object=Net::DNS::RR::APL::ApItem->new($apitem); is ( $object->string, $apitem, "String read/write correct for $apitem"); } -foreach my $apitem qw( 1:192.168.32.0.3/21 !1:192.168.32.0+21 4:FF00:0:0:0:0:0:0:0/8){ +foreach my $apitem ( qw( 1:192.168.32.0.3/21 !1:192.168.32.0+21 4:FF00:0:0:0:0:0:0:0/8) ) { my $object=Net::DNS::RR::APL::ApItem->new($apitem); diag ($object->string) unless( ok ( !defined ($object), "Incorrect format not parsed")); }
Indeed! Patch is applied in trunk. Thanks, Willem