Bug #68260 for FormValidator-Simple: LENGTH 0 validation fails

Tue May 17 04:29:07 2011 abraxxa [...] cpan.org - Ticket created

Subject:

LENGTH 0 validation fails

additional test demonstrating the bug: [ahartmai@ahartmai-nb FormValidator-Simple-0.28]$ diff -u t/08_length.t t/08_length-new.t --- t/08_length.t 2011-05-17 10:27:36.166427423 +0200 +++ t/08_length-new.t 2011-05-17 10:27:25.866412319 +0200 @@ -1,5 +1,5 @@ use strict; -use Test::More tests => 7; +use Test::More tests => 8; use CGI; BEGIN{ use_ok("FormValidator::Simple") } @@ -44,3 +44,8 @@ ok(!$r6->invalid('text')); +my $r7 = FormValidator::Simple->check( $q => [ + text => [[qw/LENGTH 0 8/]], +] ); + +ok(!$r7->invalid(''));

Mon May 30 04:21:15 2011 lyokato [...] cpan.org - Correspondence added

Show quoted text

> +ok(!$r7->invalid(''));

This should be ok(!$r7->invalid('text')); right?

Mon May 30 04:21:16 2011 The RT System itself - Status changed from 'new' to 'open'

Mon May 30 04:21:16 2011 lyokato [...] cpan.org - Status changed from 'open' to 'rejected'

Mon May 30 04:30:42 2011 abraxxa [...] cpan.org - Correspondence added

No, an empty field should be valid when the length is allowed to be zero.

Mon May 30 04:30:43 2011 The RT System itself - Status changed from 'rejected' to 'open'

Mon May 30 04:56:26 2011 lyokato [...] cpan.org - Correspondence added

On 2011-5月-30 月 04:30:42, ABRAXXA wrote: Show quoted text

> No, an empty field should be valid when the length is allowed to be zero.

I guess you misunderstood usage. maybe you want to do my $q2 = CGI->new; $q2->param( param1 => '' ); my $r8 = FormValidator::Simple->check( $q2 => [ param1 => [[qw/LENGTH 0 8/]], ] ); ok(!$r8->invalid('param1'));

Mon May 30 05:27:14 2011 abraxxa [...] cpan.org - Correspondence added

Ah, ok! This is the correct test then: --- t/08_length.t 2011-05-17 10:27:36.166427423 +0200 +++ t/08_length-new.t 2011-05-30 11:09:41.174279205 +0200 @@ -1,5 +1,5 @@ use strict; -use Test::More tests => 7; +use Test::More tests => 8; use CGI; BEGIN{ use_ok("FormValidator::Simple") } @@ -43,4 +43,10 @@ ok(!$r6->invalid('text')); +$q->param( empty => '' ); +my $r7 = FormValidator::Simple->check( $q => [ + empty => [[qw/LENGTH 0 8/]], +] ); + +ok(!$r7->invalid('empty')); Strangely this doesn't fail while my code does. You can close the ticket, I'll reopen it if I can reproduce my failure with a test case.