Skip Menu |

This queue is for tickets about the DBI CPAN distribution.

Report information
The Basics
Id: 68250
Status: resolved
Priority: 0/
Queue: DBI

People
Owner: Nobody in particular
Requestors: fred.steinberg [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.616
Fixed in: (no value)



Subject: test fails if running in dir w/"fred" in path
Trying to install w/cpanm in perlbrew-ed OS X home dir: /User/fred DBI-1.616/t/51dbm_file.t fails: Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 72. Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 81. Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 81. Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 81. DBD::DBM::db selectall_arrayref failed: -d /Users/freddy/.cpanm/work/1305577426.94245/DBI-1.616/test_output_95281: No such file or directory at /Users/fred/.cpanm/work/1305577426.94245/DBI- 1.616/blib/lib/DBD/File.pm line 730 at /Users/fred/.cpanm/work/1305577426.94245/DBI- 1.616/blib/lib/DBI/DBD/SqlEngine.pm line 795 [for Statement "select * from Krueger"] at ./t/51dbm_file.t line 86 Can't use an undefined value as an ARRAY reference at ./t/51dbm_file.t line 87. Compilation failed in require at t/zvxnp_51dbm_file.t line 6. This is what's involved: at line 71: my $fn_tbl2 = $dbh->{dbm_tables}->{fred}->{f_fqfn}; $fn_tbl2 =~ s/fred(\.[^.]*)?/freddy$1/; and 81: $tgt_fn =~ s/fred(\.[^.]*)?/freddy$1/; not sure best way to qualify the substitution to restrict only to db filename; maybe add an end-of-line match? $tgt_fn =~ s/fred(\.[^.]*)?$/freddy$1/;
Subject: Re: [rt.cpan.org #68250] test fails if running in dir w/"fred" in path
Date: Tue, 17 May 2011 09:13:02 +0200
To: bug-DBI [...] rt.cpan.org
From: Jens Rehsack <rehsack [...] googlemail.com>
2011/5/16 Fred Steinberg via RT <bug-DBI@rt.cpan.org>: Show quoted text
> Mon May 16 16:49:21 2011: Request 68250 was acted upon. > Transaction: Ticket created by freds >       Queue: DBI >     Subject: test fails if running in dir w/"fred" in path >   Broken in: 1.616 >    Severity: Unimportant >       Owner: Nobody >  Requestors: fred.steinberg@gmail.com >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=68250 >
Hi Fred, Show quoted text
> Trying to install w/cpanm in perlbrew-ed OS X home dir: /User/fred > > DBI-1.616/t/51dbm_file.t fails: > > Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 72. > Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 81. > Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 81. > Use of uninitialized value $1 in concatenation (.) or string at ./t/51dbm_file.t line 81. > DBD::DBM::db selectall_arrayref failed: -d > /Users/freddy/.cpanm/work/1305577426.94245/DBI-1.616/test_output_95281: No such > file or directory at /Users/fred/.cpanm/work/1305577426.94245/DBI- > 1.616/blib/lib/DBD/File.pm line 730 at /Users/fred/.cpanm/work/1305577426.94245/DBI- > 1.616/blib/lib/DBI/DBD/SqlEngine.pm line 795 >  [for Statement "select * from Krueger"] at ./t/51dbm_file.t line 86 > Can't use an undefined value as an ARRAY reference at ./t/51dbm_file.t line 87. > Compilation failed in require at t/zvxnp_51dbm_file.t line 6. > > This is what's involved: > > at line 71: > >    my $fn_tbl2 = $dbh->{dbm_tables}->{fred}->{f_fqfn}; >       $fn_tbl2 =~ s/fred(\.[^.]*)?/freddy$1/; > > and 81: > >        $tgt_fn =~ s/fred(\.[^.]*)?/freddy$1/; > > not sure best way to qualify the substitution to restrict only to db filename; maybe add an > end-of-line match? > >        $tgt_fn =~ s/fred(\.[^.]*)?$/freddy$1/; >
I'm really sorry - I didn't think about user directories (as me always use separate working directories). Can you please approve attached patch? Thank you very much, Jens
Download patch-RT.68250
application/octet-stream 751b

Message body not shown because it is not plain text.

From: fred.steinberg [...] gmail.com
Show quoted text
> Can you please approve attached patch?
Looks good - thanks for the quick reply! .../1305577426.94245/DBI-1.616> perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/51dbm_file.t t/51dbm_file.t .. ok All tests successful. Files=1, Tests=15, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.08 cusr 0.02 csys = 0.13 CPU) Result: PASS
Suggested patch committed, thanks Fred.